Merge branch 'feature/python-tool-build-apps-with-firebase' of https://github.com/firebase/firebase-cpp-sdk into feature/python-tool-build-apps-with-firebase

Author: vimanyu

.github/workflows/cpp-packaging.yml

@@ -1,5 +1,9 @@
 name: CPP binary SDK packaging
 on:
+  push:
+    branches:
+      # Run a full packaging step any time a new branch is merged into dev.
+      - dev
   workflow_dispatch:
     inputs:
       commitIdToPackage:
@@ -15,11 +19,14 @@ on:
 env:
   # Packaging prerequisites
   # Binutils 2.35.1 released Sep 19, 2020
-  binutilsVer: 2.35.1
+  binutilsVer: "2.35.1"
   # Demumble 1.1.0 released Nov 13, 2018
-  demumbleVer: 1.1.0
+  demumbleVer: "1.1.0"
   # Use SHA256 for hashing files.
-  hashCommand: sha256sum
+  hashCommand: "sha256sum"
+  # Xcode version 11.7 is the version we build the SDK with.
+  # Our MacOS runners will use the version in /Applications/Xcode_${xcodeVersion}.app
+  xcodeVersion: "11.7"
 
 jobs:
   log_inputs:
@@ -40,9 +47,12 @@ jobs:
               echo "::warning ::Using commit ID '${{ github.event.inputs.commitIdToPackage }}' for building and packaging SDK and tests."
             fi
           fi
-          if [[ "${{ github.event.inputs.preserveIntermediateArtifacts }}" != "0" ]]; then
-            echo "::warning ::Intermediate artifacts will be preserved."
-          fi
+
+      - name: log if preserving intermediate artifacts
+        if: |
+          github.event.inputs.preserveIntermediateArtifacts != 0 && github.event.inputs.preserveIntermediateArtifacts != '' &&
+          github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == ''
+        run: echo "::warning ::Intermediate artifacts will be preserved."
 
   build_tools:
     name: build-tools-${{ matrix.tools_platform }}
@@ -57,6 +67,10 @@ jobs:
         - os: macos-latest
           tools_platform: darwin
     steps:
+      - name: setup Xcode version (macos)
+        if: runner.os == 'macOS'
+        run: sudo xcode-select -s /Applications/Xcode_${{ env.xcodeVersion }}.app/Contents/Developer
+
       - name: fetch and build binutils
         run: |
           set +e
@@ -113,6 +127,10 @@ jobs:
     runs-on: macos-latest
     if: ${{ github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == '' }}
     steps:
+      - name: setup Xcode version (macos)
+        if: runner.os == 'macOS'
+        run: sudo xcode-select -s /Applications/Xcode_${{ env.xcodeVersion }}.app/Contents/Developer
+
       - name: fetch SDK
         uses: actions/[email protected]
         with:
@@ -240,6 +258,10 @@ jobs:
           build_type: "Debug"
 
     steps:
+      - name: setup Xcode version (macos)
+        if: runner.os == 'macOS'
+        run: sudo xcode-select -s /Applications/Xcode_${{ env.xcodeVersion }}.app/Contents/Developer
+
       - uses: actions/checkout@v2
         with:
           submodules: true
@@ -360,6 +382,10 @@ jobs:
         - sdk_platform: darwin
           runs_on_platform: ubuntu-latest
     steps:
+      - name: setup Xcode version (macos)
+        if: runner.os == 'macOS'
+        run: sudo xcode-select -s /Applications/Xcode_${{ env.xcodeVersion }}.app/Contents/Developer
+
       - name: fetch SDK
         uses: actions/[email protected]
         with:
@@ -536,7 +562,12 @@ jobs:
     name: cleanup-artifacts
     runs-on: ubuntu-latest
     needs: [merge_packages]
-    if: ${{ github.event.inputs.preserveIntermediateArtifacts == 0 && github.event.inputs.downloadPublicVersion == '' && github.event.inputs.downloadPreviousRun == '' }}
+    if: |
+      (
+        (github.event.inputs.preserveIntermediateArtifacts == 0 || github.event.inputs.preserveIntermediateArtifacts == '')
+        && github.event.inputs.downloadPublicVersion == ''
+        && github.event.inputs.downloadPreviousRun == ''
+      )
     steps:
     - uses: geekyeggo/delete-artifact@v1
       with:
@@ -576,6 +607,10 @@ jobs:
     if: always()
     runs-on: ubuntu-latest
     steps:
+      - name: setup Xcode version (macos)
+        if: runner.os == 'macOS'
+        run: sudo xcode-select -s /Applications/Xcode_${{ env.xcodeVersion }}.app/Contents/Developer
+
       - name: download SDK zip
         uses: actions/download-artifact@v2
         with:

.github/workflows/desktop.yml

@@ -6,6 +6,9 @@ on:
 
 env:
   CCACHE_DIR: ${{ github.workspace }}/ccache_dir
+  # Xcode version 11.7 is the version we build the SDK with.
+  # Our MacOS runners will use the version in /Applications/Xcode_${xcodeVersion}.app
+  xcodeVersion: "11.7"
 
 jobs:
   build:
@@ -40,6 +43,10 @@ jobs:
           msvc_runtime: "dynamic"
 
     steps:
+      - name: setup Xcode version (macos)
+        if: runner.os == 'macOS'
+        run: sudo xcode-select -s /Applications/Xcode_${{ env.xcodeVersion }}.app/Contents/Developer
+
       - uses: actions/checkout@v2
         with:
           submodules: true

.github/workflows/ios.yml

@@ -4,6 +4,11 @@ on:
   pull_request:
     types: [opened, reopened, synchronize]
 
+env:
+  # Xcode version 11.7 is the version we build the SDK with.
+  # Our MacOS runners will use the version in /Applications/Xcode_${xcodeVersion}.app
+  xcodeVersion: "11.7"
+
 jobs:
   build:
     name: ios-macos-latest
@@ -12,6 +17,10 @@ jobs:
       fail-fast: false
 
     steps:
+      - name: setup Xcode version (macos)
+        if: runner.os == 'macOS'
+        run: sudo xcode-select -s /Applications/Xcode_${{ env.xcodeVersion }}.app/Contents/Developer
+
       - uses: actions/checkout@v2
         with:
           submodules: true

build_scripts/other/package.sh

@@ -27,8 +27,8 @@ cd "${origpath}"
 # Copy headers to packaged SDK.
 mkdir -p "${destpath}/include"
 cd "${sdkpath}"
-for incdir in */src/include/; do
-    cp -af "${incdir}" "${destpath}/include/"
+for incdir in */src/include; do
+    cp -af "${incdir}" "${destpath}/"
 done
 cd "${origpath}"
 

scripts/gha/utils.py

@@ -193,8 +193,11 @@ def verify_vcpkg_build(vcpkg_triplet, attempt_auto_fix=False):
       # Manually renaming and re-running script makes it go through.
       tools_dir_path = os.path.join(vcpkg_root_dir_path, 'downloads', 'tools')
       for name in os.listdir(tools_dir_path):
+        # In the specific windows error that we noticed, the error occurs while
+        # trying to rename intermediate directories for donwloaded tools
+        # like "powershell.partial.<pid>" to "powershell". Renaming via python
+        # also runs into the same error. Workaround is to copy instead of rename.
         if '.partial.' in name and os.path.isdir(os.path.join(tools_dir_path, name)):
-          # Since we can't rename, lets copy the directory to one without partial in the name
           expected_name = name.split('.partial.')[0]
           shutil.copytree(os.path.join(tools_dir_path, name),
                           os.path.join(tools_dir_path, expected_name))