Skip to content

Commit 203286a

Browse files
authored
Merge branch 'dev' into feature/js-merge-firestore-changes
2 parents fc8a5c1 + 83666db commit 203286a

File tree

2 files changed

+19
-6
lines changed

2 files changed

+19
-6
lines changed

.github/workflows/cpp-packaging.yml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ on:
1111
preserveIntermediateArtifacts:
1212
description: 'preserve intermediate artifacts?'
1313
default: 0
14+
skipIntegrationTests:
15+
description: 'skip integration tests?'
16+
default: 0
1417
downloadPublicVersion:
1518
description: 'public version # to test against'
1619
downloadPreviousRun:
1720
description: 'previous run # to test against'
18-
runIntegrationTests:
19-
description: 'run integration tests?'
20-
default: 0
2121

2222
env:
2323
# Packaging prerequisites
@@ -49,6 +49,11 @@ jobs:
4949
fi
5050
fi
5151
52+
- name: log if skipping integration tests
53+
if: |
54+
github.event.inputs.skipIntegrationTests != 0 && github.event.inputs.skipIntegrationTests != ''
55+
run: echo "::warning ::Skipping integration tests."
56+
5257
- name: log if preserving intermediate artifacts
5358
if: |
5459
github.event.inputs.preserveIntermediateArtifacts != 0 && github.event.inputs.preserveIntermediateArtifacts != '' &&
@@ -615,7 +620,7 @@ jobs:
615620

616621
tests:
617622
needs: [merge_packages, download_sdk_package]
618-
if: github.event.inputs.runIntegrationTests != 0 && !cancelled()
623+
if: (github.event.inputs.skipIntegrationTests == 0 || github.event.inputs.skipIntegrationTests == '') && !cancelled()
619624
runs-on: ${{ matrix.os }}
620625
strategy:
621626
matrix:
@@ -693,4 +698,8 @@ jobs:
693698
- name: Summarize build and test results
694699
if: ${{ !cancelled() }}
695700
shell: bash
696-
run: cat testapps/summary.log
701+
run: |
702+
cat testapps/summary.log
703+
if [[ "${{ job.status }}" != "success" ]]; then
704+
exit 1
705+
fi

.github/workflows/integration_tests.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,4 +162,8 @@ jobs:
162162
- name: Summarize build and test results
163163
if: ${{ !cancelled() }}
164164
shell: bash
165-
run: cat testapps/summary.log
165+
run: |
166+
cat testapps/summary.log
167+
if [[ "${{ job.status }}" != "success" ]]; then
168+
exit 1
169+
fi

0 commit comments

Comments
 (0)