Commit 24b8571
committed
Address review feedback for UseUserAccessGroup
This commit addresses feedback from the pull request review for the
UseUserAccessGroup feature:
- Added a stub implementation for Android in `auth_android.cc`.
- Updated iOS implementation in `auth_ios.mm` to pass an empty NSString
(`@""`) to the native SDK if an empty C++ string is provided.
`nullptr` still results in `nil` being passed.
- Updated Doxygen comments in `auth.h` to reflect the iOS behavior for
`nullptr` and empty string inputs more accurately.
- Investigated potential NSError codes for the underlying iOS SDK method.
Confirmed that `FIRAuthErrorCodeKeychainError` is the most relevant documented
error, and it is already correctly handled by the existing C++ error
mapping.1 parent 48c8469 commit 24b8571
File tree
3 files changed
+14
-4
lines changed- auth/src
- android
- include/firebase
- ios
3 files changed
+14
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
676 | 676 | | |
677 | 677 | | |
678 | 678 | | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
679 | 684 | | |
680 | 685 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
525 | 525 | | |
526 | 526 | | |
527 | 527 | | |
528 | | - | |
529 | | - | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
530 | 535 | | |
531 | 536 | | |
532 | | - | |
| 537 | + | |
533 | 538 | | |
534 | 539 | | |
535 | 540 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
613 | 613 | | |
614 | 614 | | |
615 | 615 | | |
616 | | - | |
| 616 | + | |
617 | 617 | | |
618 | 618 | | |
619 | 619 | | |
| |||
0 commit comments