Skip to content

Commit 301e8f4

Browse files
jonsimantova-maurice
authored andcommitted
Fix an overzealous INTERNAL_EXPERIMENTAL ifdef in Auth header, which breaks the
Firestore testapp. PiperOrigin-RevId: 286904008
1 parent c69d476 commit 301e8f4

File tree

1 file changed

+3
-7
lines changed
  • auth/src/include/firebase

1 file changed

+3
-7
lines changed

auth/src/include/firebase/auth.h

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#define FIREBASE_AUTH_CLIENT_CPP_SRC_INCLUDE_FIREBASE_AUTH_H_
1919

2020
#include <vector>
21+
2122
#include "firebase/app.h"
2223
#include "firebase/future.h"
2324
#include "firebase/internal/common.h"
@@ -246,8 +247,7 @@ class Auth {
246247
/// @note: This operation is supported only on iOS and Android platforms. On
247248
/// non-mobile platforms this method will return a Future with a preset error
248249
/// code: kAuthErrorUnimplemented.
249-
Future<SignInResult> SignInWithProvider(
250-
FederatedAuthProvider* provider);
250+
Future<SignInResult> SignInWithProvider(FederatedAuthProvider* provider);
251251

252252
/// Asynchronously logs into Firebase with the given credentials.
253253
///
@@ -791,7 +791,7 @@ class FederatedAuthProvider {
791791
#endif // not SWIG
792792
#endif // INTERNAL_EXPERIMENTAL
793793

794-
FederatedAuthProvider() { }
794+
FederatedAuthProvider() {}
795795
virtual ~FederatedAuthProvider() {}
796796

797797
private:
@@ -802,7 +802,6 @@ class FederatedAuthProvider {
802802
virtual Future<SignInResult> Reauthenticate(AuthData* auth_data) = 0;
803803
};
804804

805-
806805
/// @brief Authenticates with Federated OAuth Providers via the
807806
/// firebase::auth::Auth and firebase::auth::User classes.
808807
///
@@ -813,7 +812,6 @@ class FederatedAuthProvider {
813812
/// account linking and user reauthentication, respectively.
814813
class FederatedOAuthProvider : public FederatedAuthProvider {
815814
public:
816-
#ifdef INTERNAL_EXPERIMENTAL
817815
#ifndef SWIG
818816
/// @brief A FederatedAuthProvider typed specifically for OAuth Authentication
819817
/// handling.
@@ -823,7 +821,6 @@ class FederatedOAuthProvider : public FederatedAuthProvider {
823821
typedef FederatedAuthProvider::Handler<FederatedOAuthProviderData>
824822
AuthHandler;
825823
#endif // !SWIG
826-
#endif // INTERNAL_EXPERIMENTAL
827824

828825
/// Constructs an unconfigured provider.
829826
FederatedOAuthProvider();
@@ -889,7 +886,6 @@ class FederatedOAuthProvider : public FederatedAuthProvider {
889886
AuthHandler* handler_;
890887
};
891888

892-
893889
} // namespace auth
894890
} // namespace firebase
895891

0 commit comments

Comments
 (0)