Add comments and check runner.os instead of matrix.os

Author: anonymous-akorn

.github/workflows/cpp-packaging.yml

@@ -650,7 +650,7 @@ jobs:
       with:
         python-version: '3.7'
     - name: Add msbuild to PATH (windows)
-      if: startsWith(matrix.os, 'windows')
+      if: runner.os == 'Windows'
       uses: microsoft/[email protected]
     - name: Prepare for integration tests
       run: |
@@ -663,7 +663,7 @@ jobs:
     # Workaround for https://github.com/GoogleCloudPlatform/github-actions/issues/100
     # Must be run after the Python setup action
     - name: Set CLOUDSDK_PYTHON (Windows)
-      if: startsWith(matrix.os, 'windows') && !cancelled()
+      if: runner.os == 'Windows' && !cancelled()
       run: echo "CLOUDSDK_PYTHON=${{env.pythonLocation}}\python.exe" >> $GITHUB_ENV
     - name: Install Cloud SDK
       if: ${{ !cancelled() }}

scripts/gha/build_testapps.py

@@ -399,6 +399,7 @@ def _validate_android_environment_variables():
 # If sdk_dir contains no framework, consider it is Github repo, then
 # generate makefiles for ios frameworks
 def _generate_makefiles_from_repo(sdk_dir):
+  """Generates cmake makefiles for building iOS frameworks from SDK source."""
   ios_framework_builder = os.path.join(
       sdk_dir, "build_scripts", "ios", "build.sh")
 
@@ -413,12 +414,15 @@ def _generate_makefiles_from_repo(sdk_dir):
 
 # build required ios frameworks based on makefiles
 def _build_ios_framework_from_repo(sdk_dir, api_config):
+  """Builds iOS framework from SDK source."""
   ios_framework_builder = os.path.join(
       sdk_dir, "build_scripts", "ios", "build.sh")
 
   # build only required targets to save time
   target = set()
+
   for framework in api_config.frameworks:
+    # firebase_analytics.framework -> firebase_analytics
     target.add(os.path.splitext(framework)[0])
   # firebase is not a target in CMake, firebase_app is the target
   # firebase_app will be built by other target as well