Skip to content

Commit 5ac7955

Browse files
smilesa-maurice
authored andcommitted
Fix tests incorrectly instancing firebase::App on desktop.
api_key and app_id are required options when creating a firebase::App instance, this moves all tests to use a header-only library that provides a mock AppOptions with the required parameters set. In addition, the header library handles platform abstraction for the creation of firebase::App in the test environment. PiperOrigin-RevId: 261342319
1 parent c96a8c4 commit 5ac7955

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

remote_config/src/desktop/rest.cc

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,28 +222,39 @@ void RemoteConfigREST::ParseProtoResponse(const std::string& proto_str) {
222222
// Start with a copy of the fetched config state.
223223
NamespaceKeyValueMap config_map(configs_.fetched.config());
224224

225+
LogDebug("Parsing config response...");
225226
for (auto app_config : response.configs) {
227+
LogDebug("Found response config checking app name %s vs %s",
228+
app_package_name_.c_str(), app_config.app_name.c_str());
226229
// Check the same app name.
227230
if (app_package_name_.compare(app_config.app_name) != 0) continue;
228231

232+
LogDebug("Parsing config for app...");
229233
for (auto config : app_config.ns_configs) {
230234
switch (config.status) {
231235
case CONFIG_NAMESPACESTATUS(NO_CHANGE):
232236
meta_digest[config.config_namespace] = config.digest;
237+
LogDebug("No change: ns=%s digest=%s",
238+
config.config_namespace.c_str(), config.digest.c_str());
233239
break;
234240
case CONFIG_NAMESPACESTATUS(UPDATE):
235241
meta_digest[config.config_namespace] = config.digest;
236242
config_map[config.config_namespace].clear();
237243
for (auto keyvalue : config.key_values) {
238244
config_map[config.config_namespace][keyvalue.key] = keyvalue.value;
245+
LogDebug("Update: ns=%s kv=(%s, %s)",
246+
config.config_namespace.c_str(), keyvalue.key.c_str(),
247+
keyvalue.value.c_str());
239248
}
240249
break;
241250
case CONFIG_NAMESPACESTATUS(NO_TEMPLATE):
242251
case CONFIG_NAMESPACESTATUS(NOT_AUTHORIZED):
252+
LogDebug("NotAuthorized: ns=%s", config.config_namespace.c_str());
243253
meta_digest.erase(config.config_namespace);
244254
config_map.erase(config.config_namespace);
245255
break;
246256
case CONFIG_NAMESPACESTATUS(EMPTY_CONFIG):
257+
LogDebug("EmptyConfig: ns=%s", config.config_namespace.c_str());
247258
meta_digest[config.config_namespace] = config.digest;
248259
config_map[config.config_namespace].clear();
249260
break;

0 commit comments

Comments
 (0)