Skip to content

Commit 5e5cbc9

Browse files
Fix desktop integration test execution in the packaging workflow
Build and execution has been separated and was applied to the integration_tests workflow, but not the cpp-packaging workflow.
1 parent 0316583 commit 5e5cbc9

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

.github/workflows/cpp-packaging.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -658,10 +658,14 @@ jobs:
658658
run: |
659659
pip install -r scripts/gha/requirements.txt
660660
python scripts/gha/restore_secrets.py --passphrase "${{ secrets.TEST_SECRET }}"
661-
- name: Build integration tests (and run Desktop tests)
661+
- name: Build integration tests
662662
run: |
663-
python scripts/gha/build_testapps.py --t ${{ env.apis }} --p ${{ matrix.target_platform }} --sdk_dir firebase_cpp_sdk --output_directory ${{ github.workspace }} --execute_desktop_testapp --noadd_timestamp
664-
663+
python scripts/gha/build_testapps.py --t ${{ env.apis }} --p ${{ matrix.target_platform }} --sdk_dir firebase_cpp_sdk --output_directory ${{ github.workspace }} --noadd_timestamp
664+
665+
- name: Run desktop integration tests
666+
if: matrix.target_platform == 'Desktop' && !cancelled()
667+
run: |
668+
python scripts/gha/desktop_tester.py --testapp_dir testapps
665669
# Workaround for https://github.com/GoogleCloudPlatform/github-actions/issues/100
666670
# Must be run after the Python setup action
667671
- name: Set CLOUDSDK_PYTHON (Windows)

.github/workflows/integration_tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,11 +136,11 @@ jobs:
136136
- name: Upload Desktop Artifacts to GCS
137137
if: matrix.target_platform == 'Desktop' && !cancelled()
138138
run: |
139-
python scripts/gha/gcs_uploader.py --testapp_dir ${{ github.workspace }}/testapps --key_file ${{ github.workspace }}/scripts/gha-encrypted/gcs_key_file.json
139+
python scripts/gha/gcs_uploader.py --testapp_dir testapps --key_file scripts/gha-encrypted/gcs_key_file.json
140140
- name: Run mobile integration tests
141141
if: matrix.target_platform != 'Desktop' && !cancelled()
142142
run: |
143-
python scripts/gha/test_lab.py --android_model ${{ github.event.inputs.android_device }} --android_api ${{ github.event.inputs.android_api }} --ios_model ${{ github.event.inputs.ios_device }} --ios_version ${{ github.event.inputs.ios_version }} --testapp_dir ${{ github.workspace }}/testapps --code_platform cpp --key_file ${{ github.workspace }}/scripts/gha-encrypted/gcs_key_file.json
143+
python scripts/gha/test_lab.py --android_model ${{ github.event.inputs.android_device }} --android_api ${{ github.event.inputs.android_api }} --ios_model ${{ github.event.inputs.ios_device }} --ios_version ${{ github.event.inputs.ios_version }} --testapp_dir testapps --code_platform cpp --key_file scripts/gha-encrypted/gcs_key_file.json
144144
- name: Summarize build and test results
145145
if: ${{ !cancelled() }}
146146
shell: bash

0 commit comments

Comments
 (0)