Skip to content

Commit 5ec7287

Browse files
authored
Disable GMA stress tests on iOS in CI to limit ad pool exhaustion errors (#1141)
Suppresses the AdView, InterstitialAd and RewardedAd stress tests on iOS in CI. These tests were exhausting the ad pool for the iOS ad unit and therefore causing NoFill errors, or even worse, BackOff errors.
1 parent fe79031 commit 5ec7287

File tree

1 file changed

+6
-18
lines changed

1 file changed

+6
-18
lines changed

gma/integration_test/src/integration_test.cc

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2015,11 +2015,9 @@ TEST_F(FirebaseGmaTest, TestRewardedAdErrorBadExtrasClassName) {
20152015
// Stress tests. These take a while so run them near the end.
20162016
TEST_F(FirebaseGmaTest, TestAdViewStress) {
20172017
SKIP_TEST_ON_DESKTOP;
2018-
SKIP_TEST_ON_SIMULATOR;
20192018

2020-
// Loading Ads has been deemed flaky as the AdMob Service has a chance to
2021-
// return NoFill for valid ad requests if there aren't any ads to serve.
2022-
FLAKY_TEST_SECTION_BEGIN();
2019+
// TODO(@drsanta): remove when GMA whitelists CI devices
2020+
TEST_REQUIRES_USER_INTERACTION_ON_IOS;
20232021

20242022
for (int i = 0; i < 10; ++i) {
20252023
const firebase::gma::AdSize banner_ad_size(kBannerWidth, kBannerHeight);
@@ -2037,17 +2035,13 @@ TEST_F(FirebaseGmaTest, TestAdViewStress) {
20372035
WaitForCompletion(ad_view->Destroy(), "Destroy the AdView");
20382036
delete ad_view;
20392037
}
2040-
2041-
FLAKY_TEST_SECTION_END();
20422038
}
20432039

20442040
TEST_F(FirebaseGmaTest, TestInterstitialAdStress) {
20452041
SKIP_TEST_ON_DESKTOP;
2046-
SKIP_TEST_ON_SIMULATOR;
20472042

2048-
// Loading Ads has been deemed flaky as the AdMob Service has a chance to
2049-
// return NoFill for valid ad requests if there aren't any ads to serve.
2050-
FLAKY_TEST_SECTION_BEGIN();
2043+
// TODO(@drsanta): remove when GMA whitelists CI devices
2044+
TEST_REQUIRES_USER_INTERACTION_ON_IOS;
20512045

20522046
for (int i = 0; i < 10; ++i) {
20532047
firebase::gma::InterstitialAd* interstitial =
@@ -2063,17 +2057,13 @@ TEST_F(FirebaseGmaTest, TestInterstitialAdStress) {
20632057
"TestInterstitialAdStress LoadAd");
20642058
delete interstitial;
20652059
}
2066-
2067-
FLAKY_TEST_SECTION_END();
20682060
}
20692061

20702062
TEST_F(FirebaseGmaTest, TestRewardedAdStress) {
20712063
SKIP_TEST_ON_DESKTOP;
2072-
SKIP_TEST_ON_SIMULATOR;
20732064

2074-
// Loading Ads has been deemed flaky as the AdMob Service has a chance to
2075-
// return NoFill for valid ad requests if there aren't any ads to serve.
2076-
FLAKY_TEST_SECTION_BEGIN();
2065+
// TODO(@drsanta): remove when GMA whitelists CI devices
2066+
TEST_REQUIRES_USER_INTERACTION_ON_IOS;
20772067

20782068
for (int i = 0; i < 10; ++i) {
20792069
firebase::gma::RewardedAd* rewarded = new firebase::gma::RewardedAd();
@@ -2087,8 +2077,6 @@ TEST_F(FirebaseGmaTest, TestRewardedAdStress) {
20872077
"TestRewardedAdStress LoadAd");
20882078
delete rewarded;
20892079
}
2090-
2091-
FLAKY_TEST_SECTION_END();
20922080
}
20932081

20942082
#if defined(ANDROID) || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)

0 commit comments

Comments
 (0)