Skip to content

Commit 5fd58e8

Browse files
committed
better ignore matching for android packages.
1 parent 5d541d3 commit 5fd58e8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

scripts/update_android_ios_dependencies.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ def get_latest_maven_versions(ignore_packages=None):
438438
for group_child in group_xml:
439439
package_name = group_child.tag.replace('-', '_')
440440
package_full_name = group_name + "." + package_name
441-
if any(ignore_package.lower() in package_full_name.lower()
441+
if any(ignore_package.lower().replace('-', '_') in package_full_name.lower()
442442
for ignore_package in ignore_packages):
443443
continue
444444
package_version = group_child.attrib['versions'].split(',')[-1]
@@ -705,7 +705,7 @@ def main():
705705

706706
if not args.skip_android:
707707
latest_android_versions_map = get_latest_maven_versions(
708-
args.ignore_android_packages)
708+
set(args.ignore_android_packages))
709709
dep_files = get_files(args.depfiles, file_extension='.gradle',
710710
file_name='firebase_dependencies.gradle',
711711
ignore_directories=set(args.ignore_directories))

0 commit comments

Comments
 (0)