Skip to content

Commit 6e7e120

Browse files
committed
Address feedback and update readmes
1 parent b96fd5f commit 6e7e120

File tree

3 files changed

+3
-18
lines changed

3 files changed

+3
-18
lines changed

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ iOS, and desktop platforms. It includes the following Firebase libraries:
1515

1616
<br>
1717

18-
**Note:** The Google Mobile Ads (GMA) C++ SDK has been deprecated and was removed from this SDK.
19-
20-
<br>
21-
2218
Firebase is an app development platform with tools to help you build, grow and monetize your app. More information about Firebase can be found [HERE](https://firebase.google.com).
2319

2420
- More information about the Firebase C++ SDK can be found [HERE](https://firebase.google.com/docs/cpp/setup)

release_build_files/readme.md

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -605,24 +605,11 @@ Firestore | Required
605605
Functions | Required
606606
Installations | Not Required
607607
Instance ID | Required
608-
Google Mobile Ads | Not required (usually; see below)
609608
Realtime Database | Required
610609
Remote Config | Required
611610
Storage | Required
612611
User Messaging Platform | Not required
613612

614-
#### A note on Google Mobile Ads and Google Play services
615-
616-
Most versions of the Google Mobile Ads SDK for Android can work properly without
617-
Google Play services. However, if you are using the
618-
`com.google.android.gms:play-services-ads-lite` dependency instead of the
619-
standard `com.google.firebase:firebase-ads` dependency, Google Play services
620-
WILL be required in your specific case.
621-
622-
GMA initialization will only return `kInitResultFailedMissingDependency` when
623-
Google Play services is unavailable AND you are using
624-
`com.google.android.gms:play-services-ads-lite`.
625-
626613
### Desktop project setup
627614

628615
To use desktop workflow support, you must have an Android or iOS project set up
@@ -656,7 +643,7 @@ code.
656643
provides a more direct way for Firebase to interact with your specified
657644
AppDelegate. See "Platform Notes > iOS Method Swizzling >
658645
Specifying Your AppDelegate Class Directly (iOS)" for details.
659-
- Google Mobile Ads (GMA) C++ SDK has been removed from the Firebase C++ SDK.
646+
- Google Mobile Ads (GMA) has been removed from the Firebase C++ SDK.
660647
It was previously deprecated. For more information, see the
661648
[SDK documentation](https://developers.google.com/admob/cpp/sdk).
662649

scripts/gha/report_build_status.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,8 @@ def format_errors(all_errors, severity, event):
191191

192192
if product == 'missing_log':
193193
product_name = 'missing logs'
194+
elif product == 'ump':
195+
product_name = product.upper()
194196
else:
195197
product_name = product.replace('_', ' ').title()
196198

0 commit comments

Comments
 (0)