Skip to content

Commit 6ec0081

Browse files
Fix: Use StorageReference::is_valid() in assertions
Changed FIREBASE_ASSERT_RETURN to use is_valid() instead of internal_->is_valid() in StorageReference::ListAll() and StorageReference::List() methods. This corrects the compilation error where 'is_valid' was not a member of the internal PIMPL class. The assertion now correctly checks the validity of the public StorageReference object before proceeding.
1 parent fe5f663 commit 6ec0081

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

storage/src/common/storage_reference.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,12 +257,12 @@ Future<Metadata> StorageReference::PutFileLastResult() {
257257
bool StorageReference::is_valid() const { return internal_ != nullptr; }
258258

259259
Future<ListResult> StorageReference::ListAll() {
260-
FIREBASE_ASSERT_RETURN(Future<ListResult>(), internal_->is_valid());
260+
FIREBASE_ASSERT_RETURN(Future<ListResult>(), is_valid());
261261
return internal_->ListAll();
262262
}
263263

264264
Future<ListResult> StorageReference::List(const char* page_token) {
265-
FIREBASE_ASSERT_RETURN(Future<ListResult>(), internal_->is_valid());
265+
FIREBASE_ASSERT_RETURN(Future<ListResult>(), is_valid());
266266
return internal_->List(page_token);
267267
}
268268

0 commit comments

Comments
 (0)