Merge pull request #173 from firebase/feature/js-android-abis

Build all Android ABIs available in NDK r16b.

The most recent versions of the NDK don't support the "mips", "mips64", and "armeabi" ABIs, but we still do ship those with the binary C++ SDK to support older devices. This change adds a check to our Android gradle build, which determines whether a custom NDK is being used (as we do in our packaging step), and builds those additional ABIs if the NDK version is the one we expect.

Our custom Android build script supports building with NDK r16b to enable all 3 STL variants as well as the aforementioned older ABIs.

This change also includes an option to build the armeabi-v7a-hard ABI, which was removed a few years ago and subsumed into armeabi-v7a, and thus shouldn't normally be required. (But if you do need armeabi-v7a-hard for some reason, you can use NDK r11c.)

Author: jonsimantov

admob/build.gradle

@@ -86,6 +86,7 @@ android {
 dependencies {
   implementation project(':app')
 }
+apply from: "$rootDir/android_build_files/android_abis.gradle"
 apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
 apply from: "$rootDir/android_build_files/generate_proguard.gradle"
 project.afterEvaluate {

analytics/build.gradle

@@ -86,6 +86,7 @@ android {
 dependencies {
   implementation project(':app')
 }
+apply from: "$rootDir/android_build_files/android_abis.gradle"
 apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
 apply from: "$rootDir/android_build_files/generate_proguard.gradle"
 project.afterEvaluate {

android_build_files/android_abis.gradle

@@ -0,0 +1,41 @@
+// Copyright 2018 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Set the list of Android ABIs depending on whether we the NDK_ROOT environment
+// variable contains the text 'r16b' in it. This will generally only occur
+// during C++ packaging, which uses /tmp/android-ndk-r16b as the NDK directory.
+// When using this NDK version, add a few additional ABIs that are only
+// supported in r16b and earlier.
+
+android {
+  defaultConfig {
+    ndk {
+      // Default list of ABIs available in up-to-date NDK.
+      abiFilters "x86", "armeabi-v7a", "arm64-v8a", "x86_64"
+      
+      if (System.getenv('NDK_ROOT').contains('r16b') ||
+          System.getenv('NDK_ROOT').contains('r11c')) {
+        // Deprecated ABIs are added to the list when building using older NDKs only.
+        // Rather than an exhaustive list, we only support r11c and r16b.
+        abiFilters.add("armeabi")
+        abiFilters.add("mips")
+        abiFilters.add("mips64")
+        if (System.getenv('NDK_ROOT').contains('r11c')) {
+          abiFilters.add("armeabi-v7a-hard")  // Removed after r11c.
+        }
+      }
+    }
+  }
+}
+

app/build.gradle

@@ -79,6 +79,7 @@ android {
   }
 }
 
+apply from: "$rootDir/android_build_files/android_abis.gradle"
 apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
 apply from: "$rootDir/android_build_files/generate_proguard.gradle"
 project.afterEvaluate {

auth/build.gradle

@@ -86,6 +86,7 @@ android {
 dependencies {
   implementation project(':app')
 }
+apply from: "$rootDir/android_build_files/android_abis.gradle"
 apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
 apply from: "$rootDir/android_build_files/generate_proguard.gradle"
 project.afterEvaluate {

database/build.gradle

@@ -86,6 +86,7 @@ android {
 dependencies {
   implementation project(':app')
 }
+apply from: "$rootDir/android_build_files/android_abis.gradle"
 apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
 apply from: "$rootDir/android_build_files/generate_proguard.gradle"
 project.afterEvaluate {

dynamic_links/build.gradle

@@ -86,6 +86,7 @@ android {
 dependencies {
   implementation project(':app')
 }
+apply from: "$rootDir/android_build_files/android_abis.gradle"
 apply from: "$rootDir/android_build_files/generate_proguard.gradle"
 project.afterEvaluate {
   generateProguardFile('dynamic_links')

firestore/build.gradle

@@ -86,6 +86,7 @@ android {
 dependencies {
   implementation project(':app')
 }
+apply from: "$rootDir/android_build_files/android_abis.gradle"
 apply from: "$rootDir/android_build_files/extract_and_dex.gradle"
 apply from: "$rootDir/android_build_files/generate_proguard.gradle"
 project.afterEvaluate {

functions/build.gradle

@@ -86,6 +86,7 @@ android {
 dependencies {
   implementation project(':app')
 }
+apply from: "$rootDir/android_build_files/android_abis.gradle"
 apply from: "$rootDir/android_build_files/generate_proguard.gradle"
 project.afterEvaluate {
   generateProguardFile('functions')

instance_id/build.gradle

@@ -86,6 +86,7 @@ android {
 dependencies {
   implementation project(':app')
 }
+apply from: "$rootDir/android_build_files/android_abis.gradle"
 apply from: "$rootDir/android_build_files/generate_proguard.gradle"
 project.afterEvaluate {
   generateProguardFile('instance_id')