Commit 7913774
Prevent the race condition between AppGetOrCreateInstance and AppReleaseReference
This potentially fix b/121161177 which crash at callback::Terminate().
Also do nullptr check in callback::Terminate() to make it a bit more durable.
The result of the race is that the developer or any C# module may get a FirebaseApp through FirebaseApp.DefaultInstance or FirebaseApp.GetInstance() which is pointing to a C++ App scheduled to be deleted and result in double deletion to the same C++ App.
PiperOrigin-RevId: 2517359131 parent cec32ee commit 7913774
1 file changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
234 | 236 | | |
235 | 237 | | |
236 | 238 | | |
| |||
0 commit comments