Skip to content

Commit 7bc7198

Browse files
chkuang-ga-maurice
authored andcommitted
LogWarning instead of assert if App is deleted before the Functions, Crashlytics and FireStore.
Also update Crashlytics to use DeleteInternal() to handle the double deletion from CleanupNotifier and destructor. PiperOrigin-RevId: 249295255
1 parent 4677c17 commit 7bc7198

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

functions/src/common/functions.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "app/src/cleanup_notifier.h"
2424
#include "app/src/include/firebase/app.h"
2525
#include "app/src/include/firebase/version.h"
26+
#include "app/src/log.h"
2627
#include "app/src/util.h"
2728

2829
#ifdef __APPLE__
@@ -108,8 +109,7 @@ Functions::Functions(::firebase::App* app, const char *region) {
108109
assert(app_notifier);
109110
app_notifier->RegisterObject(this, [](void *object) {
110111
Functions* functions = reinterpret_cast<Functions*>(object);
111-
FIREBASE_ASSERT_MESSAGE(
112-
false,
112+
LogWarning(
113113
"Functions object 0x%08x should be deleted before the App 0x%08x "
114114
"it depends upon.",
115115
static_cast<int>(reinterpret_cast<intptr_t>(functions)),

0 commit comments

Comments
 (0)