Analytics windows dll update (#1791)

* Update to use the latest analytics dll and source headers to account for latest changes.

Add latest google_analytics.dll and corresponding public header files.  Also added the implementations for SetLogCallback and NotifyAppLifecycleChange.

* Update analytics.h

Add missing header file.

* Added integration tests

Added integration test and removed the ability to set logging callback for now.  Will add in the future.

* Update analytics/src/include/firebase/analytics.h

Fix typo

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Fix formatting

* Fix formatting

* Format fixes

* Update mobile dependencies - Fri Oct 10 2025 (#1794)

* Update mobile dependencies - Fri Oct 10 2025

### Android

- com.google.android.gms.play_services_base → 18.9.0
- com.google.firebase.firebase_bom → 34.4.0

### iOS

- Firebase/Analytics → 12.4.0
- Firebase/AppCheck → 12.4.0
- Firebase/Auth → 12.4.0
- Firebase/Core → 12.4.0
- Firebase/CoreOnly → 12.4.0
- Firebase/Crashlytics → 12.4.0
- Firebase/Database → 12.4.0
- Firebase/Firestore → 12.4.0
- Firebase/Functions → 12.4.0
- Firebase/Installations → 12.4.0
- Firebase/Messaging → 12.4.0
- Firebase/RemoteConfig → 12.4.0
- Firebase/Storage → 12.4.0
- FirebaseFirestore → 12.4.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/18415569893).

* Update readme.md

* Update cpp_sdk_version.json

---------

Co-authored-by: firebase-workflow-trigger-bot <[email protected]>
Co-authored-by: a-maurice <[email protected]>

* Update the python version used by GHA runners (#1797)

* Feat: add UseEmulator to storage api (#1795)

* Feat: add UseEmulator to storage api

* Fix formating

* Update storage/src/desktop/storage_desktop.h

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update release_build_files/readme.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Fix the storage util as storagePath now needs storageinternal ref

To get the url to show up correctly the storage path now depends upon
the storage internal to query for the host and port

* Change the Release Notes and change the UseEmulator to give errors

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Feat: add in no ops for NotifyApplifecyclechange

* fix formatting

* fix the wrong param type

* fixup the wording for NotifyApplifecyclechange to be windows only

* feat: add in the Setlogcallback function for desktop analytics

* Remove double implementation of the loglevel

* Fix up the formatting and the enum in tc

* format fix up and make test win only

* Add in threading considerations for the callback test

* Add in future header to the integration tests

* Add in timeout to the test

* Fix formatting and comments

* Up the timeout to see if that helps to have the callback fire

* Try to get an error from the underlying analytics dll

* Trying to trigger the logger with an lifecycle change event

* Make the wrapper function explicitly a c extern

Also make sure nothing strange is happening with concurrency

* fix spelling of wrapper

* Try to increase the logging verbosity for a pass in actions

* Makesure the DLL is  loaded

* Revert "Makesure the DLL is  loaded"

This reverts commit 063a08e.

* Revert "Try to increase the logging verbosity for a pass in actions"

This reverts commit 872764d.

* Fix up before review

* Fix formatting

* Explain the new test

* fixup from comments

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com>
Co-authored-by: firebase-workflow-trigger-bot <[email protected]>
Co-authored-by: a-maurice <[email protected]>
Co-authored-by: Austin Benoit <[email protected]>

Author: 6 people

.github/workflows/integration_tests.yml

@@ -360,7 +360,7 @@ jobs:
         if: startsWith(matrix.os, 'windows')
         shell: bash
         run: |
-          find "testapps-desktop-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.ssl_variant }}" -name integration_test.exe -exec dirname {} \; | while read dir; do cp analytics/windows/analytics_win.dll "$dir/"; done
+          find "testapps-desktop-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.ssl_variant }}" -name integration_test.exe -exec dirname {} \; | while read dir; do cp analytics/windows/google_analytics.dll "$dir/"; done
       - name: Upload Desktop Cmake
         uses: actions/upload-artifact@v4
         if: ${{ !cancelled() }}

.gitignore

@@ -17,6 +17,7 @@ __pycache__/
 
 ### IDE generated files
 .vscode/
+**/.vs/
 
 # Unencrypted secret files
 google-services.json

analytics/generate_windows_stubs.py

@@ -262,7 +262,7 @@ def generate_function_pointers(dll_file_path, header_file_path, output_h_path, o
     )
     parser.add_argument(
         "--windows_dll",
-        default = os.path.join(os.path.dirname(sys.argv[0]), "windows/analytics_win.dll"),
+        default = os.path.join(os.path.dirname(sys.argv[0]), "windows/google_analytics.dll"),
         help="Path to the DLL file to calculate a hash."
     )
     parser.add_argument(

analytics/integration_test/CMakeLists.txt

@@ -211,7 +211,7 @@ else()
     )
   elseif(MSVC)
     set(ADDITIONAL_LIBS advapi32 ws2_32 crypt32)
-    set(ANALYTICS_WINDOWS_DLL "${FIREBASE_CPP_SDK_DIR}/analytics/windows/analytics_win.dll")
+    set(ANALYTICS_WINDOWS_DLL "${FIREBASE_CPP_SDK_DIR}/analytics/windows/google_analytics.dll")
 
     # For Windows, check if the Analytics DLL exists, and copy it in if so.
     if (EXISTS "${ANALYTICS_WINDOWS_DLL}")

analytics/integration_test/src/integration_test.cc

@@ -15,10 +15,12 @@
 #include <inttypes.h>
 
 #include <algorithm>
+#include <chrono>
 #include <cstdio>
 #include <cstdlib>
 #include <cstring>
 #include <ctime>
+#include <future>
 
 #include "app_framework.h"  // NOLINT
 #include "firebase/analytics.h"
@@ -242,6 +244,36 @@ TEST_F(FirebaseAnalyticsTest, TestSetProperties) {
       InitiateOnDeviceConversionMeasurementWithHashedPhoneNumber(hashed_phone);
 }
 
+#if defined(_WIN32)
+// The windows analytics DLL enables users to // set a callback function that is
+// triggered when the underlying DLL logs something.
+TEST_F(FirebaseAnalyticsTest, TestSetLogCallback) {
+  std::promise<void> finishedPromise;
+  std::future<void> finished = finishedPromise.get_future();
+  bool log_callback_called = false;
+
+  firebase::analytics::SetLogCallback(
+      [&](firebase::LogLevel log_level, const char* message) {
+        log_callback_called = true;
+        finishedPromise.set_value();
+      });
+
+  // Sending a NotifyAppLifecycleChange with kUnknown will trigger a logging
+  // callback
+  firebase::analytics::NotifyAppLifecycleChange(firebase::analytics::kUnknown);
+
+  if (finished.wait_for(std::chrono::seconds(60)) ==
+      std::future_status::timeout) {
+    ADD_FAILURE() << "Timed out waiting for log callback";
+  } else {
+    finished.get();
+  }
+
+  EXPECT_TRUE(log_callback_called);
+  firebase::analytics::SetLogCallback(nullptr);
+}
+#endif  // defined(_WIN32)
+
 TEST_F(FirebaseAnalyticsTest, TestLogEvents) {
   // Log an event with no parameters.
   firebase::analytics::LogEvent(firebase::analytics::kEventLogin);
@@ -259,6 +291,14 @@ TEST_F(FirebaseAnalyticsTest, TestLogEvents) {
                                 "spoon_welders");
 }
 
+TEST_F(FirebaseAnalyticsTest, TestNotifyAppLifecycleChange) {
+  // Can't confirm that these do anything but just run them all to ensure the
+  // app doesn't crash.
+  firebase::analytics::NotifyAppLifecycleChange(firebase::analytics::kUnknown);
+  firebase::analytics::NotifyAppLifecycleChange(
+      firebase::analytics::kTermination);
+}
+
 TEST_F(FirebaseAnalyticsTest, TestLogEventWithMultipleParameters) {
   const firebase::analytics::Parameter kLevelUpParameters[] = {
       firebase::analytics::Parameter(firebase::analytics::kParameterLevel, 5),

analytics/src/analytics_android.cc

@@ -666,6 +666,12 @@ void ResetAnalyticsData() {
   util::CheckAndClearJniExceptions(env);
 }
 
+// NO-OP in Android and iOS. Only used in Windows.
+void SetLogCallback(const LogCallback&) {}
+
+// NO-OP in Android and iOS. Only used in Windows.
+void NotifyAppLifecycleChange(AppLifecycleState) {}
+
 Future<std::string> GetAnalyticsInstanceId() {
   FIREBASE_ASSERT_RETURN(GetAnalyticsInstanceIdLastResult(),
                          internal::IsInitialized());

analytics/src/analytics_desktop.cc

@@ -12,7 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+#include <future>
 #include <map>
+#include <mutex>
 #include <sstream>
 #include <string>
 #include <vector>
@@ -25,6 +27,7 @@
 #include "app/src/include/firebase/future.h"
 #include "app/src/include/firebase/variant.h"
 #include "app/src/log.h"
+#include "firebase/log.h"
 
 #if defined(_WIN32)
 #include <windows.h>
@@ -36,14 +39,16 @@ namespace firebase {
 namespace analytics {
 
 #if defined(_WIN32)
-#define ANALYTICS_DLL_FILENAME L"analytics_win.dll"
+#define ANALYTICS_DLL_FILENAME L"google_analytics.dll"
 
 static HMODULE g_analytics_module = 0;
 #endif  // defined(_WIN32)
 
 // Future data for analytics.
 // This is initialized in `Initialize()` and cleaned up in `Terminate()`.
 static bool g_initialized = false;
+static LogCallback g_log_callback;
+static std::mutex g_log_callback_mutex;
 static int g_fake_instance_id = 0;
 static bool g_analytics_collection_enabled = true;
 static std::string g_app_id;
@@ -134,6 +139,10 @@ bool IsInitialized() { return g_initialized; }
 void Terminate() {
 #if defined(_WIN32)
   if (g_analytics_module) {
+    // Make sure to notify the SDK that the analytics is being terminated to
+    // upload any pending data.
+    NotifyAppLifecycleChange(AppLifecycleState::kTermination);
+
     FirebaseAnalytics_UnloadDynamicFunctions();
     FreeLibrary(g_analytics_module);
     g_analytics_module = 0;
@@ -386,6 +395,61 @@ void ResetAnalyticsData() {
   g_fake_instance_id++;
 }
 
+LogLevel ConvertAnalyticsLogLevelToFirebaseLogLevel(
+    GoogleAnalytics_LogLevel log_level) {
+  switch (log_level) {
+    case kDebug:
+      return kLogLevelDebug;
+    case kInfo:
+      return kLogLevelInfo;
+    case kWarning:
+      return kLogLevelWarning;
+    case kError:
+      return kLogLevelError;
+    default:
+      return kLogLevelInfo;
+  }
+}
+
+void GoogleAnalyticsWrapperLogCallback(GoogleAnalytics_LogLevel log_level,
+                                       const char* message) {
+  LogCallback callback_to_call;
+
+  {
+    std::lock_guard<std::mutex> lock(g_log_callback_mutex);
+    callback_to_call = g_log_callback;
+  }
+
+  if (callback_to_call) {
+    LogLevel firebase_log_level =
+        ConvertAnalyticsLogLevelToFirebaseLogLevel(log_level);
+    callback_to_call(firebase_log_level, message);
+  }
+}
+
+// Allows the passing of a callback to be used when the SDK logs any
+// messages regarding its behavior. The callback must be thread-safe.
+void SetLogCallback(const LogCallback& callback) {
+  FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
+  // The C API does not support user data, so we must use a global variable.
+  {
+    std::lock_guard<std::mutex> lock(g_log_callback_mutex);
+    g_log_callback = callback;
+  }
+  if (callback) {
+    GoogleAnalytics_SetLogCallback(GoogleAnalyticsWrapperLogCallback);
+  } else {
+    GoogleAnalytics_SetLogCallback(nullptr);
+  }
+}
+
+// Notify the Analytics SDK about the current state of the app's lifecycle.
+void NotifyAppLifecycleChange(AppLifecycleState state) {
+  FIREBASE_ASSERT_RETURN_VOID(internal::IsInitialized());
+  GoogleAnalytics_NotifyAppLifecycleChange(
+      static_cast<GoogleAnalytics_AppLifecycleState>(state));
+}
+
 // Overloaded versions of LogEvent for convenience.
 
 void LogEvent(const char* name) {