Skip to content

Commit 80513fb

Browse files
authored
[Bugfix] Test on Simulator/Emulator crash when missing test log
1 parent edad366 commit 80513fb

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

scripts/gha/test_simulator.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -423,15 +423,15 @@ def _run_apple_gameloop_test(bundle_id, app_path, gameloop_app, device_id, retry
423423
logging.info("Running apple gameloop test: %s, %s, %s, %s", bundle_id, app_path, gameloop_app, device_id)
424424
_install_apple_app(app_path, device_id)
425425
_run_xctest(gameloop_app, device_id)
426-
logs = _get_apple_test_log(bundle_id, app_path, device_id)
426+
log = _get_apple_test_log(bundle_id, app_path, device_id)
427427
_uninstall_apple_app(bundle_id, device_id)
428428
if retry > 1:
429-
results = test_validation.validate_results_cpp(logs)
430-
if not results.complete:
429+
result = test_validation.validate_results(log, test_validation.CPP)
430+
if not result.complete:
431431
logging.info("Retry _run_apple_gameloop_test. Remaining retry: %s", retry-1)
432432
return _run_apple_gameloop_test(bundle_id, app_path, gameloop_app, device_id, retry=retry-1)
433433

434-
return logs
434+
return log
435435

436436

437437
def _install_apple_app(app_path, device_id):
@@ -563,15 +563,15 @@ def _run_android_gameloop_test(package_name, app_path, gameloop_project, retry=1
563563
logging.info("Running android gameloop test: %s, %s, %s", package_name, app_path, gameloop_project)
564564
_install_android_app(app_path)
565565
_run_instrumented_test()
566-
logs = _get_android_test_log(package_name)
566+
log = _get_android_test_log(package_name)
567567
_uninstall_android_app(package_name)
568568
if retry > 1:
569-
results = test_validation.validate_results_cpp(logs)
570-
if not results.complete:
569+
result = test_validation.validate_results(log, test_validation.CPP)
570+
if not result.complete:
571571
logging.info("Retry _run_android_gameloop_test. Remaining retry: %s", retry-1)
572572
return _run_android_gameloop_test(package_name, app_path, gameloop_project, retry=retry-1)
573573

574-
return logs
574+
return log
575575

576576

577577
def _install_android_app(app_path):

0 commit comments

Comments
 (0)