Skip to content

Commit 8d6d7d6

Browse files
committed
Update JNI usage and add method definition.
1 parent fff19ca commit 8d6d7d6

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

analytics/src/analytics_android.cc

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ static const ::firebase::App* g_app = nullptr;
5858
"()Lcom/google/android/gms/tasks/Task;"), \
5959
X(GetSessionId, "getSessionId", \
6060
"()Lcom/google/android/gms/tasks/Task;"), \
61+
X(SetDefaultEventParameters, "setDefaultEventParameters", \
62+
"(Landroid/os/Bundle;)V"), \
6163
X(GetInstance, "getInstance", "(Landroid/content/Context;)" \
6264
"Lcom/google/firebase/analytics/FirebaseAnalytics;", \
6365
firebase::util::kMethodTypeStatic)
@@ -755,27 +757,27 @@ void SetDefaultEventParameters(
755757
jni_value =
756758
env->NewObject(util::integer_class::GetClass(),
757759
util::bundle::GetMethodId(util::bundle::kConstructor),
758-
pair.second.int64_value());
760+
pair.second.int64_value());
759761
} else if (pair.second.is_double()) {
760762
jni_value =
761763
env->NewObject(util::double_class::GetClass(),
762764
util::bundle::GetMethodId(util::bundle::kConstructor),
763-
pair.second.double_value());
765+
pair.second.double_value());
764766
} else if (pair.second.is_string()) {
765767
jni_value =
766768
env->NewObject(util::string::GetClass(),
767769
util::bundle::GetMethodId(util::bundle::kConstructor));
768770
} else if (pair.second.is_map()) {
769-
jni_value = env->NewStringUTF(pair.second.c_str());
771+
jni_value = env->NewStringUTF(pair.second.string_value());
770772
} else {
771773
// A Variant type that couldn't be handled was passed in.
772774
LogError(
773775
"LogEvent(%s): %s is not a valid parameter value type. "
774776
"No event was logged.",
775-
pair.first.c_str(), Variant::TypeName(pair.second.type()));
777+
pair.first.string_value(), Variant::TypeName(pair.second.type()));
776778
continue;
777779
}
778-
jstring key_string = env->NewStringUTF(pair.first.c_str());
780+
jstring key_string = env->NewStringUTF(pair.first.string_value());
779781
jobject previous_value =
780782
env->CallObjectMethod(map, put_method_id, key_string, jni_value);
781783
util::CheckAndClearJniExceptions(env);

0 commit comments

Comments
 (0)