Guard remote config response parsing from empty FlatBuffer

triplef · triplef · commit 8d73b86723c6 · 2025-09-26T08:55:14.000+02:00
Fixes #1433.
diff --git a/remote_config/src/desktop/remote_config_response.cc b/remote_config/src/desktop/remote_config_response.cc
@@ -95,6 +95,9 @@ void RemoteConfigResponse::MarkCompleted() {
     return;
   }
   const flatbuffers::FlatBufferBuilder& builder = parser_->builder_;
+  if (builder.GetSize() == 0 || builder.GetBufferPointer() == nullptr) {
+    return;
+  }
   const fbs::Response* body_fbs =
       flatbuffers::GetRoot<fbs::Response>(builder.GetBufferPointer());
 

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,9 @@ void RemoteConfigResponse::MarkCompleted() {`
`95`	`95`	`return;`
`96`	`96`	`}`
`97`	`97`	`const flatbuffers::FlatBufferBuilder& builder = parser_->builder_;`
	`98`	`+ if (builder.GetSize() == 0 \|\| builder.GetBufferPointer() == nullptr) {`
	`99`	`+ return;`
	`100`	`+ }`
`98`	`101`	`const fbs::Response* body_fbs =`
`99`	`102`	`flatbuffers::GetRoot<fbs::Response>(builder.GetBufferPointer());`
`100`	`103`