Skip to content

Commit 93df99d

Browse files
Fix builds of windows integration tests caused by messed up path
When ${{ github.workspace }} gets resolved, it has windows separators in it, which are getting lost when passed as a flag to the Python script. i.e. what starts as D:\a\firebase-cpp-sdk\firebase-cpp-sdk turns into afirebase-cpp-sdkfirebase-cpp-sdk Wrapping the value in quotes prevents these slashes from being lost.
1 parent 3103434 commit 93df99d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/cpp-packaging.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@ jobs:
667667
python scripts/gha/restore_secrets.py --passphrase "${{ secrets.TEST_SECRET }}"
668668
- name: Build integration tests
669669
run: |
670-
python scripts/gha/build_testapps.py --t ${{ env.apis }} --p ${{ matrix.target_platform }} --sdk_dir firebase_cpp_sdk --output_directory ${{ github.workspace }} --noadd_timestamp
670+
python scripts/gha/build_testapps.py --t ${{ env.apis }} --p ${{ matrix.target_platform }} --sdk_dir firebase_cpp_sdk --output_directory "${{ github.workspace }}" --noadd_timestamp
671671
672672
- name: Run desktop integration tests
673673
if: matrix.target_platform == 'Desktop' && !cancelled()

.github/workflows/integration_tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ jobs:
136136
if [[ "${{ matrix.ssl_variant }}" == "boringssl" ]]; then
137137
ssl_option=--cmake_flag=-DFIREBASE_USE_BORINGSSL=ON
138138
fi
139-
python scripts/gha/build_testapps.py --t ${{ github.event.inputs.apis }} --p ${{ matrix.target_platform }} --output_directory ${{ github.workspace }} --use_vcpkg --noadd_timestamp ${ssl_option}
139+
python scripts/gha/build_testapps.py --t ${{ github.event.inputs.apis }} --p ${{ matrix.target_platform }} --output_directory "${{ github.workspace }}" --use_vcpkg --noadd_timestamp ${ssl_option}
140140
141141
- name: Run desktop integration tests
142142
if: matrix.target_platform == 'Desktop' && !cancelled()

0 commit comments

Comments
 (0)