Add App Check to the packaging logic (#1292)

* Add App Check logic to the GHA CI

* Disable the failure tests

* Formatting

* Update debug_token_request.h

* Update app_check_android.cc

* Update integration_test.cc

* Update integration_test.cc

* Simplify the App Check test

* Update integration_test.cc

* Update integration_test.cc

---------

Co-authored-by: Jon Simantov <[email protected]>

Author: a-maurice

.github/workflows/cpp-packaging.yml

@@ -827,7 +827,7 @@ jobs:
             -w integration_tests.yml \
             -p test_packaged_sdk ${{ github.run_id }} \
             -p use_expanded_matrix ${USE_EXPANDED_MATRIX} \
-            -p apis "analytics,auth,database,dynamic_links,functions,installations,messaging,remote_config,storage" \
+            -p apis "analytics,app_check,auth,database,dynamic_links,functions,installations,messaging,remote_config,storage" \
             -p test_pull_request nightly-packaging \
             -s 10 \
             -A ${verbose_flag}

.github/workflows/integration_tests.yml

@@ -17,7 +17,7 @@ on:
         required: true
       apis:
         description: 'CSV of apis to build and test'
-        default: 'analytics,auth,database,dynamic_links,firestore,functions,gma,installations,messaging,remote_config,storage'
+        default: 'analytics,app_check,auth,database,dynamic_links,firestore,functions,gma,installations,messaging,remote_config,storage'
         required: true
       operating_systems:
         description: 'CSV of VMs to run on'
@@ -187,7 +187,7 @@ jobs:
         # list. Then we can use fromJson to define the field in the matrix for the tests job.
         if [[ "${{ github.event.schedule }}" == "0 9 * * *" ]]; then
           # at 1am PST/2am PDT. Running integration tests and generate test report for all testapps except firestore
-          apis="analytics,auth,database,dynamic_links,functions,gma,installations,messaging,remote_config,storage"
+          apis="analytics,app_check,auth,database,dynamic_links,functions,gma,installations,messaging,remote_config,storage"
         elif [[ "${{ github.event.schedule }}" == "0 10 * * *" || "${{ github.event.schedule }}" == "0 11 * * *" ]]; then
           # at 2am PST/3am PDT and 3am PST/4am PDT. Running integration tests for firestore and generate test report.
           apis="firestore"

app_check/integration_test/CMakeLists.txt

@@ -235,7 +235,7 @@ endif()
 # Add the Firebase libraries to the target using the function from the SDK.
 add_subdirectory(${FIREBASE_CPP_SDK_DIR} bin/ EXCLUDE_FROM_ALL)
 # Note that firebase_app needs to be last in the list.
-set(firebase_libs firebase_app_check firebase_database firebase_storage firebase_functions firebase_firestore firebase_auth firebase_app)
+set(firebase_libs firebase_app_check firebase_database firebase_storage firebase_functions firebase_auth firebase_app)
 set(gtest_libs gtest gmock)
 target_link_libraries(${integration_test_target_name} ${firebase_libs}
   ${gtest_libs} ${ADDITIONAL_LIBS})

app_check/integration_test/Podfile

@@ -9,7 +9,6 @@ target 'integration_test' do
   pod 'Firebase/Auth', '10.9.0'
   pod 'Firebase/Storage', '10.9.0'
   pod 'Firebase/Functions', '10.9.0'
-  pod 'Firebase/Firestore', '10.9.0'
 end
 
 target 'integration_test_tvos' do
@@ -19,7 +18,6 @@ target 'integration_test_tvos' do
   pod 'Firebase/Auth', '10.9.0'
   pod 'Firebase/Storage', '10.9.0'
   pod 'Firebase/Functions', '10.9.0'
-  pod 'Firebase/Firestore', '10.9.0'
 end
 
 post_install do |installer|

app_check/integration_test/build.gradle

@@ -65,8 +65,7 @@ android {
         "-DFIREBASE_INCLUDE_AUTH=ON",
         "-DFIREBASE_INCLUDE_DATABASE=ON",
         "-DFIREBASE_INCLUDE_STORAGE=ON",
-        "-DFIREBASE_INCLUDE_FUNCTIONS=ON",
-        "-DFIREBASE_INCLUDE_FIRESTORE=ON"
+        "-DFIREBASE_INCLUDE_FUNCTIONS=ON"
     }
     multiDexEnabled true
   }
@@ -95,7 +94,6 @@ firebaseCpp.dependencies {
   database
   storage
   functions
-  firestore
 }
 
 apply plugin: 'com.google.gms.google-services'

app_check/integration_test/integration_test.xcodeproj/xcshareddata/xcschemes/integration_test.xcscheme

@@ -50,13 +50,6 @@
             ReferencedContainer = "container:integration_test.xcodeproj">
          </BuildableReference>
       </BuildableProductRunnable>
-      <EnvironmentVariables>
-         <EnvironmentVariable
-            key = "FIRAAppCheckDebugToken"
-            value = "REPLACE_WITH_APP_CHECK_TOKEN"
-            isEnabled = "YES">
-         </EnvironmentVariable>
-      </EnvironmentVariables>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"

app_check/integration_test/integration_test.xcodeproj/xcshareddata/xcschemes/integration_test_tvos.xcscheme

@@ -50,13 +50,6 @@
             ReferencedContainer = "container:integration_test.xcodeproj">
          </BuildableReference>
       </BuildableProductRunnable>
-      <EnvironmentVariables>
-         <EnvironmentVariable
-            key = "FIRAAppCheckDebugToken"
-            value = "REPLACE_WITH_APP_CHECK_TOKEN"
-            isEnabled = "YES">
-         </EnvironmentVariable>
-      </EnvironmentVariables>
    </LaunchAction>
    <ProfileAction
       buildConfiguration = "Release"