Skip to content

Commit 9c5e5a5

Browse files
authored
Fix Mac integration tests: don't append a line to Firestore core cmake file in build_desktop.py (#242)
* Remove append from build_desktop.py as it breaks things on Mac.
1 parent e9904b4 commit 9c5e5a5

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

scripts/gha/build_desktop.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -228,12 +228,6 @@ def main():
228228
cmake_configure(args.build_dir, args.arch, args.msvc_runtime_library, args.linux_abi,
229229
args.build_tests, args.config, args.target_format)
230230

231-
# Small workaround before build, turn off -Werror=sign-compare for a specific Firestore core lib.
232-
if not utils.is_windows_os():
233-
append_line_to_file(os.path.join(args.build_dir,
234-
'external/src/firestore/Firestore/core/CMakeLists.txt'),
235-
'set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error=sign-compare")')
236-
237231
# CMake build
238232
# cmake --build build -j 8
239233
cmd = ['cmake', '--build', args.build_dir, '-j', str(os.cpu_count()),

0 commit comments

Comments
 (0)