[Auth][macOS] remove the check for NSUserDefaults for keychain ever exist.

The issue we are running into is: with this check, if replace SDK in Unity, system would think it's a different app and there is no way to remove / replace existing key entry for the app.

PiperOrigin-RevId: 265091403

Author: cynthiajiang

app/src/secure/user_secure_darwin_internal.h

@@ -49,12 +49,6 @@ class UserSecureDarwinInternal : public UserSecureInternal {
   void DeleteAllData() override;
 
  private:
-  // Does the user have secure data set for this app? Don't access the keychain
-  // unless this is true.
-  bool UserHasSecureData();
-  // Set whether the user has secure data set for this app.
-  void SetUserHasSecureData(bool b);
-
   // Delete either a single key, or (if app_name is null) all keys.
   // func_name is used for error messages.
   void DeleteData(const char* app_name, const char* func_name);

app/src/secure/user_secure_darwin_internal.mm

@@ -80,27 +80,7 @@
   return service_ + "/" + app;
 }
 
-bool UserSecureDarwinInternal::UserHasSecureData() {
-  NSUserDefaults* defaults = [NSUserDefaults standardUserDefaults];
-  if (!defaults) {
-    // For some reason we can't get NSUserDefaults, so just err on the safe side and return true so
-    // we check the keychain directly.
-    return true;
-  }
-  return [defaults boolForKey:@(user_defaults_key_.c_str())] ? true : false;
-}
-
-void UserSecureDarwinInternal::SetUserHasSecureData(bool b) {
-  NSUserDefaults* defaults = [NSUserDefaults standardUserDefaults];
-  [defaults setBool:(b ? YES : NO) forKey:@(user_defaults_key_.c_str())];
-  [defaults synchronize];
-}
-
 std::string UserSecureDarwinInternal::LoadUserData(const std::string& app_name) {
-  if (!UserHasSecureData()) {
-    LogDebug("LoadUserData: User has no data stored.");
-    return "";
-  }
   NSMutableDictionary* query = GetQueryForApp(service_.c_str(), app_name.c_str());
   std::string keystore_location = GetKeystoreLocation(app_name);
   // We want to return the data and attributes.
@@ -164,16 +144,9 @@
              error_string.UTF8String);
     return;
   }
-
-  SetUserHasSecureData(true);
 }
 
 void UserSecureDarwinInternal::DeleteData(const char* app_name, const char* func_name) {
-  if (!UserHasSecureData()) {
-    LogDebug("%s: User has no data stored.", func_name);
-    return;
-  }
-
   NSMutableDictionary* query = GetQueryForApp(service_.c_str(), app_name);
   std::string keystore_location = app_name ? GetKeystoreLocation(app_name) : service_;
 
@@ -201,7 +174,6 @@
 
 void UserSecureDarwinInternal::DeleteAllData() {
   DeleteData(nullptr, "DeleteAllData");
-  SetUserHasSecureData(false);
 }
 
 }  // namespace secure