Skip to content

Commit c33ef95

Browse files
Googlera-maurice
authored andcommitted
Copybara Firestore
PiperOrigin-RevId: 333174406
1 parent f32e36e commit c33ef95

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

firestore/src/tests/validation_test.cc

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -571,35 +571,35 @@ TEST_F(ValidationTest, QueriesWithNullOrNaNFiltersOtherThanEqualityFail) {
571571
FAIL() << "should throw exception";
572572
} catch (const FirestoreException& exception) {
573573
EXPECT_STREQ(
574-
"Invalid Query. Null supports only equality comparisons (via "
575-
"whereEqualTo()).",
574+
"Invalid Query. Null only supports comparisons via whereEqualTo() and "
575+
"whereNotEqualTo().",
576576
exception.what());
577577
}
578578
try {
579579
collection.WhereArrayContains("a", FieldValue::Null());
580580
FAIL() << "should throw exception";
581581
} catch (const FirestoreException& exception) {
582582
EXPECT_STREQ(
583-
"Invalid Query. Null supports only equality comparisons (via "
584-
"whereEqualTo()).",
583+
"Invalid Query. Null only supports comparisons via whereEqualTo() and "
584+
"whereNotEqualTo().",
585585
exception.what());
586586
}
587587
try {
588588
collection.WhereGreaterThan("a", FieldValue::Double(NAN));
589589
FAIL() << "should throw exception";
590590
} catch (const FirestoreException& exception) {
591591
EXPECT_STREQ(
592-
"Invalid Query. NaN supports only equality comparisons (via "
593-
"whereEqualTo()).",
592+
"Invalid Query. NaN only supports comparisons via whereEqualTo() and "
593+
"whereNotEqualTo().",
594594
exception.what());
595595
}
596596
try {
597597
collection.WhereArrayContains("a", FieldValue::Double(NAN));
598598
FAIL() << "should throw exception";
599599
} catch (const FirestoreException& exception) {
600600
EXPECT_STREQ(
601-
"Invalid Query. NaN supports only equality comparisons (via "
602-
"whereEqualTo()).",
601+
"Invalid Query. NaN only supports comparisons via whereEqualTo() and "
602+
"whereNotEqualTo().",
603603
exception.what());
604604
}
605605
}
@@ -735,8 +735,9 @@ TEST_F(ValidationTest, QueriesWithDifferentInequalityFieldsFail) {
735735
FAIL() << "should throw exception";
736736
} catch (const FirestoreException& exception) {
737737
EXPECT_STREQ(
738-
"All where filters other than whereEqualTo() must be on the same "
739-
"field. But you have filters on 'x' and 'y'",
738+
"All where filters with an inequality (notEqualTo, notIn, lessThan, "
739+
"lessThanOrEqualTo, greaterThan, or greaterThanOrEqualTo) must be on "
740+
"the same field. But you have filters on 'x' and 'y'",
740741
exception.what());
741742
}
742743
}

0 commit comments

Comments
 (0)