Skip to content

Commit c380f02

Browse files
Adjust UseUserAccessGroup integration test per review
The test now calls UseUserAccessGroup without checking its return value. This is to prevent failures in environments where keychain sharing might not be configured, as the primary goal of this test is to ensure the method call itself doesn't crash on iOS.
1 parent c8f87a3 commit c380f02

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

auth/integration_test/src/integration_test.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1516,14 +1516,14 @@ TEST_F(FirebaseAuthTest, TestLinkFederatedProviderBadProviderIdFails) {
15161516
#if TARGET_OS_IPHONE
15171517
TEST_F(FirebaseAuthTest, TestUseUserAccessGroup) {
15181518
// This is a simple smoke test to ensure the method can be called
1519-
// without crashing on iOS and returns the expected default success.
1519+
// without crashing on iOS.
15201520
// Deeper testing of keychain access group functionality would require
15211521
// more complex setup and is typically done manually or with UI tests.
1522-
EXPECT_EQ(auth_->UseUserAccessGroup(nullptr),
1523-
firebase::auth::kAuthErrorNone);
1524-
EXPECT_EQ(auth_->UseUserAccessGroup("test-group"),
1525-
firebase::auth::kAuthErrorNone);
1526-
EXPECT_EQ(auth_->UseUserAccessGroup(""), firebase::auth::kAuthErrorNone);
1522+
// We don't check the return value as keychain sharing may not be configured,
1523+
// leading to legitimate errors.
1524+
auth_->UseUserAccessGroup(nullptr);
1525+
auth_->UseUserAccessGroup("test-group");
1526+
auth_->UseUserAccessGroup("");
15271527
}
15281528
#endif // TARGET_OS_IPHONE
15291529

0 commit comments

Comments
 (0)