Skip to content

Commit c3f1124

Browse files
Merge pull request #212 from firebase/feature/aks-fix-packaging-test
Minor fixes to testing in the packaging workflow
2 parents 5b2a57a + 87f41b9 commit c3f1124

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

.github/workflows/cpp-packaging.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -653,15 +653,19 @@ jobs:
653653
python-version: '3.7'
654654
- name: Add msbuild to PATH (windows)
655655
if: runner.os == 'Windows'
656-
uses: microsoft/[email protected].1
656+
uses: microsoft/[email protected].2
657657
- name: Prepare for integration tests
658658
run: |
659659
pip install -r scripts/gha/requirements.txt
660660
python scripts/gha/restore_secrets.py --passphrase "${{ secrets.TEST_SECRET }}"
661-
- name: Build integration tests (and run Desktop tests)
661+
- name: Build integration tests
662662
run: |
663-
python scripts/gha/build_testapps.py --t ${{ env.apis }} --p ${{ matrix.target_platform }} --sdk_dir firebase_cpp_sdk --output_directory ${{ github.workspace }} --execute_desktop_testapp --noadd_timestamp
664-
663+
python scripts/gha/build_testapps.py --t ${{ env.apis }} --p ${{ matrix.target_platform }} --sdk_dir firebase_cpp_sdk --output_directory ${{ github.workspace }} --noadd_timestamp
664+
665+
- name: Run desktop integration tests
666+
if: matrix.target_platform == 'Desktop' && !cancelled()
667+
run: |
668+
python scripts/gha/desktop_tester.py --testapp_dir testapps
665669
# Workaround for https://github.com/GoogleCloudPlatform/github-actions/issues/100
666670
# Must be run after the Python setup action
667671
- name: Set CLOUDSDK_PYTHON (Windows)

.github/workflows/integration_tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,11 @@ jobs:
154154
- name: Upload Desktop Artifacts to GCS
155155
if: matrix.target_platform == 'Desktop' && !cancelled()
156156
run: |
157-
python scripts/gha/gcs_uploader.py --testapp_dir ${{ github.workspace }}/testapps --key_file ${{ github.workspace }}/scripts/gha-encrypted/gcs_key_file.json
157+
python scripts/gha/gcs_uploader.py --testapp_dir testapps --key_file scripts/gha-encrypted/gcs_key_file.json
158158
- name: Run mobile integration tests
159159
if: matrix.target_platform != 'Desktop' && !cancelled()
160160
run: |
161-
python scripts/gha/test_lab.py --android_model ${{ github.event.inputs.android_device }} --android_api ${{ github.event.inputs.android_api }} --ios_model ${{ github.event.inputs.ios_device }} --ios_version ${{ github.event.inputs.ios_version }} --testapp_dir ${{ github.workspace }}/testapps --code_platform cpp --key_file ${{ github.workspace }}/scripts/gha-encrypted/gcs_key_file.json
161+
python scripts/gha/test_lab.py --android_model ${{ github.event.inputs.android_device }} --android_api ${{ github.event.inputs.android_api }} --ios_model ${{ github.event.inputs.ios_device }} --ios_version ${{ github.event.inputs.ios_version }} --testapp_dir testapps --code_platform cpp --key_file scripts/gha-encrypted/gcs_key_file.json
162162
- name: Summarize build and test results
163163
if: ${{ !cancelled() }}
164164
shell: bash

0 commit comments

Comments
 (0)