Skip to content

Commit cabc9c2

Browse files
committed
Revert "Remove x86 Linux support."
This reverts commit 9ede958.
1 parent e2e9d8c commit cabc9c2

File tree

5 files changed

+9
-16
lines changed

5 files changed

+9
-16
lines changed

.github/workflows/cpp-packaging.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,8 +342,6 @@ jobs:
342342
linux_abi: "c++11"
343343
- os: macos-13
344344
build_type: "Debug"
345-
- os: ubuntu-22.04
346-
architecture: "x86"
347345
- os: ubuntu-22.04
348346
msvc_runtime: "dynamic"
349347
- os: ubuntu-22.04

.github/workflows/desktop.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ jobs:
7777
# architecture excluees
7878
- os: macos-13
7979
architecture: "x86"
80-
- os: ubuntu-22.04
81-
architecture: "x86"
8280
# Xcode excludes -- allow only one on osx and linux
8381
- os: ubuntu-22.04
8482
xcode_version: "11.7"

.github/workflows/integration_tests.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -270,11 +270,9 @@ jobs:
270270
arch: arm64
271271
- os: ubuntu-22.04
272272
arch: arm64
273-
# Do not attempt to use x86 on Mac or Linux.
273+
# Do not attempt to use x86 on Mac.
274274
- os: macos-13
275275
arch: x86
276-
- os: ubuntu-22.04
277-
arch: x86
278276
# Until we support building openssl from source, we can't use the
279277
# system's openssl when cross-compiling, except on Linux. Builds all
280278
# happen on x64 machines, so arm64 and x86 are technically
@@ -754,11 +752,9 @@ jobs:
754752
arch: arm64
755753
- os: ubuntu-22.04
756754
arch: arm64
757-
# Do not attempt to use x86 on Mac or Linux.
755+
# Do not attempt to use x86 on Mac.
758756
- os: macos-13
759757
arch: x86
760-
- os: ubuntu-22.04
761-
arch: x86
762758
# Until we support building openssl from source, we can't use the
763759
# system's openssl when cross-compiling, except on Linux. Builds all
764760
# happen on x64 machines, so arm64 and x86 are technically

scripts/gha/print_matrix_configuration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
"matrix": {
7676
"os": ["ubuntu-22.04", "macos-13"],
7777
"build_type": ["Release", "Debug"],
78-
"architecture": ["x64"],
78+
"architecture": ["x64", "x86"],
7979
"msvc_runtime": ["static","dynamic"],
8080
"xcode_version": ["15.1"],
8181
"python_version": ["3.7"],
@@ -129,7 +129,7 @@
129129
"android_device": ["android_target", "android_latest", "emulator_ftl_target", "emulator_ftl_latest"],
130130
"ios_device": ["ios_min", "ios_target", "ios_latest", "simulator_min", "simulator_target", "simulator_latest"],
131131
"tvos_device": ["tvos_simulator"],
132-
"architecture_windows_linux": ["x64"],
132+
"architecture_windows_linux": ["x64", "x86"],
133133
"architecture_macos": ["x64"],
134134
}
135135
},

scripts/gha/utils.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,10 @@ def install_x86_support_libraries(gha_build=False):
235235
downgrading Ubuntu packages).
236236
"""
237237
if is_linux_os():
238-
packages = ['gcc-multilib', 'g++-multilib', 'libglib2.0-dev:i386',
238+
packages = ['gcc-10-multilib', 'g++-10-multilib', 'libglib2.0-dev:i386',
239239
'libsecret-1-dev:i386', 'libpthread-stubs0-dev:i386',
240-
'libssl-dev:i386', 'libsecret-1-0:i386']
240+
'libssl-dev:i386', 'libsecret-1-0:i386', 'libgcc-s1:i386',
241+
'gcc-10-base:i386']
241242
remove_packages = []
242243

243244
# First check if these packages exist on the machine already
@@ -255,8 +256,8 @@ def install_x86_support_libraries(gha_build=False):
255256
if gha_build:
256257
# Remove libpcre to prevent package conflicts.
257258
# Only remove packages on GitHub runners.
258-
remove_packages = ['libpcre2-dev:amd64', 'libpcre2-32-0:amd64',
259-
'libpcre2-8-0:amd64', 'libpcre2-16-0:amd64']
259+
remove_packages = ['libpcre2-16-0:amd64', 'libpcre2-32-0:amd64', 'libpcre2-8-0:amd64',
260+
'libpcre2-posix3:amd64', 'libpcre2-dev:amd64', 'pcre2-utils:amd64']
260261
# Note: With aptitude, you can remove package 'xyz' by specifying 'xyz-'
261262
# in the package list.
262263
run_command(['aptitude', 'install', '-V', '-y'] + packages +

0 commit comments

Comments
 (0)