Skip to content

Commit cbfe192

Browse files
amabluea-maurice
authored andcommitted
Added limit.h to the list of headers so that Guitar builds start working.
A macro called NAME_MAX is being used in the code, which is supposed to originate in limits.h, which was previously not included in messaging.cc. However, local builds still work, so I assume that it was being included trasitively and it was just never an issue. However Guitar fails because it can't find NAME_MAX, so there must be a subtle difference in the toolchain that Guitar is using that results in this failure. PiperOrigin-RevId: 244924017
1 parent 5b98f59 commit cbfe192

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

messaging/src/android/cpp/messaging.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,18 @@
1313
// limitations under the License.
1414

1515
#include "messaging/src/include/firebase/messaging.h"
16+
1617
#include <assert.h>
1718
#include <jni.h>
19+
#include <limits.h>
1820
#include <pthread.h>
1921
#include <stdio.h>
2022
#include <sys/file.h>
2123
#include <sys/inotify.h>
2224
#include <sys/stat.h>
2325
#include <time.h>
2426
#include <unistd.h>
27+
2528
#include <set>
2629
#include <string>
2730

0 commit comments

Comments
 (0)