Skip to content

Commit d554ba5

Browse files
committed
added temporary default values for some flags.
There are TODOs to remove these defaults when they are not needed but it makes running these command much easier for the person handling the release.
1 parent 572bb4e commit d554ba5

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

scripts/update_android_ios_dependencies.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -666,14 +666,19 @@ def parse_cmdline_args():
666666
help='Just print the replaced lines, DO NOT overwrite any files')
667667
parser.add_argument( "--log_level", default="info",
668668
help="Logging level (debug, warning, info)")
669+
# TODO: remove default values when we decide to update androidx for
670+
# gameloop_android as well.
669671
parser.add_argument('--ignore_directories', nargs='+',
672+
default=('gameloop_android', 'scripts'),
670673
help='Ignore updating any files in these directories (names).')
671674
parser.add_argument('--allow_experimental', action='store_true',
672675
help='Allow updating to experimental versions (eg:1.2.3-alpha))')
673676
# iOS options
674677
parser.add_argument('--skip_ios', action='store_true',
675678
help='Skip iOS pod version update completely.')
679+
# TODO: remove default values when Ads SDK does not need to be pinned.
676680
parser.add_argument('--ignore_ios_pods', nargs='+',
681+
default=('Google-Mobile-Ads-SDK',),
677682
help='Ignore iOS pods which have any of the items specified in '
678683
'this list as substrings.')
679684
parser.add_argument('--podfiles', nargs='+', default=(os.getcwd(),),
@@ -683,7 +688,9 @@ def parse_cmdline_args():
683688
# Android options
684689
parser.add_argument('--skip_android', action='store_true',
685690
help='Skip Android libraries version update completely.')
691+
# TODO: remove default values when Ads SDK does not need to be pinned.
686692
parser.add_argument('--ignore_android_packages', nargs='+',
693+
default=('firebase-ads',),
687694
help='Ignore Android packages which have any of the items '
688695
'specified in this list as substrings.')
689696
parser.add_argument('--depfiles', nargs='+',

0 commit comments

Comments
 (0)