Skip to content

Commit e41ca77

Browse files
committed
addressed code review comments.
1 parent 78353cd commit e41ca77

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

scripts/gha/build_ios_tvos.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,19 @@
2020
2121
It does the following,
2222
- Build ios and tvos libraries via cmake (after downloading corresponding
23-
cocoapods)
23+
cocoapods).
2424
- Create a "universal" framework if all platforms and architectures were built.
25-
- Create "xcframeworks" combining both ios and tvos frameworks under one roof.
25+
- Create "xcframeworks" combining both ios and tvos frameworks.
2626
2727
Usage examples:
2828
# Build all supported targets and architectures on all platforms.
2929
python3 scripts/gha/build_ios_tvos.py
3030
31-
3231
# Build specific targets
3332
python3 scripts/gha/build_ios_tvos.py -t firebase_auth firebase_database
3433
3534
# Build for specific architectures
3635
python3 scripts/gha/build_ios_tvos.py -p arm64 -t firebase_remote_config
37-
3836
"""
3937

4038
import argparse
@@ -128,7 +126,7 @@ def arrange_frameworks(archive_output_path):
128126
def build_universal_framework(frameworks_path):
129127
"""Create universal frameworks if possible.
130128
131-
If all architectures (eg: arm64, armv7 etc) and platforms(device, simulator)
129+
If all architectures (eg: arm64, armv7 etc) and platforms (device, simulator)
132130
were built, combine all of the libraries into a single universal framework.
133131
Args:
134132
frameworks_path (str): Root path containing subdirectories for each
@@ -447,9 +445,10 @@ def cmake_configure_and_build(build_path, toolchain,
447445
archive_output_path (str): Path to build and save libraries/frameworks to.
448446
targets (list(str)): CMake build targets. (eg: firebase_auth, etc)
449447
architecture (str, optional): Architecture passed onto the cmake build
450-
system. Used when building for ios only. Defaults to None.
448+
system. Used when building for ios only. (eg:'arm64', 'x86_64')
451449
toolchain_platform (str, optional): Platform cmake option passed for tvos
452-
builds only. Defaults to None.
450+
builds only. Accepts all platforms supported by the tvos toolchain.
451+
(eg: 'TVOS', 'SIMULATOR_TVOS' etc)
453452
"""
454453
cmd = ['cmake', '-S', '.', '-B', build_path]
455454
cmd.append('-DCMAKE_TOOLCHAIN_FILE={0}'.format(toolchain))

0 commit comments

Comments
 (0)