Skip to content

Commit e8749f5

Browse files
Remove deprecated User::UpdateEmail from C++ SDK and tests
Matching a change made in the Unity SDK, this commit removes: - Auth: `User::UpdateEmail` and `User::UpdateEmailLastResult` methods. Integration tests in `ta/auth/it/src/integration_test.cc` were updated: - Removed a call to `UpdateEmail` on an invalid user. - Removed commented-out calls to `UpdateEmail` in `TestUpdateEmailAndPassword`. Updated the release notes to reflect this change.
1 parent b5022d8 commit e8749f5

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

auth/integration_test/src/integration_test.cc

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -761,18 +761,13 @@ TEST_F(FirebaseAuthTest, TestUpdateEmailAndPassword) {
761761
firebase::auth::User user = auth_->current_user();
762762
EXPECT_TRUE(user.is_valid());
763763

764-
// Update the user's email and password.
765-
// const std::string new_email = "new_" + email;
766-
// WaitForCompletion(user.UpdateEmail(new_email.c_str()), "UpdateEmail");
764+
// Update the user's password.
765+
// Email update functionality has been changed and the old UpdateEmail method removed.
766+
// A more comprehensive test for the new email update flow
767+
// (SendEmailVerificationBeforeUpdatingEmail) would be needed here.
767768
WaitForCompletion(user.UpdatePassword(kTestPasswordUpdated),
768769
"UpdatePassword");
769770

770-
// firebase::auth::Credential new_email_cred =
771-
// firebase::auth::EmailAuthProvider::GetCredential(new_email.c_str(),
772-
// kTestPasswordUpdated);
773-
// WaitForCompletion(user.Reauthenticate(new_email_cred), "Reauthenticate");
774-
// EXPECT_TRUE(user.is_valid());
775-
776771
WaitForCompletion(user.SendEmailVerification(), "SendEmailVerification");
777772
DeleteUser();
778773
}

0 commit comments

Comments
 (0)