Skip to content

Commit ea00d1f

Browse files
jonsimantova-maurice
authored andcommitted
Add actual error message reporting to libsecret errors.
PiperOrigin-RevId: 289549757
1 parent f2566d5 commit ea00d1f

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

app/src/secure/user_secure_linux_internal.cc

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ std::string UserSecureLinuxInternal::LoadUserData(const std::string& app_name) {
6969
/* value1= */ app_name.c_str(), /* key2= */ kStorageDomainKey,
7070
/* value2= */ domain_.c_str(), nullptr);
7171
if (error) {
72+
LogWarning("Secret lookup failed. Error %d: %s", error->code,
73+
error->message);
7274
g_error_free(error);
73-
LogWarning("Secret lookup failed, please make sure libsecret is "
74-
"installed.");
7575
return empty_str;
7676
}
7777

@@ -98,8 +98,9 @@ void UserSecureLinuxInternal::SaveUserData(const std::string& app_name,
9898
/* key2= */ kStorageDomainKey, /* value2= */ domain_.c_str(), nullptr);
9999

100100
if (error) {
101+
LogWarning("Secret store failed. Error %d: %s", error->code,
102+
error->message);
101103
g_error_free(error);
102-
LogWarning("Secret store failed, please make sure libsecret is installed.");
103104
}
104105
}
105106

@@ -116,8 +117,9 @@ void UserSecureLinuxInternal::DeleteUserData(const std::string& app_name) {
116117
/* value2= */ domain_.c_str(), nullptr);
117118

118119
if (error) {
120+
LogWarning("Secret clear failed. Error %d: %s", error->code,
121+
error->message);
119122
g_error_free(error);
120-
LogWarning("Secret clear failed, please make sure libsecret is installed.");
121123
}
122124
}
123125

@@ -131,8 +133,9 @@ void UserSecureLinuxInternal::DeleteAllData() {
131133
/* key2= */ kStorageDomainKey,
132134
/* value2= */ domain_.c_str(), nullptr);
133135
if (error) {
136+
LogWarning("Secret clear failed. Error %d: %s", error->code,
137+
error->message);
134138
g_error_free(error);
135-
LogWarning("Secret clear failed, please make sure libsecret is installed.");
136139
}
137140
}
138141

0 commit comments

Comments
 (0)