Skip to content

Commit eea7eff

Browse files
authored
Merge branch 'dev' into feature/aks-improve-logging
2 parents bdc8c48 + 05f847d commit eea7eff

File tree

3 files changed

+17
-8
lines changed

3 files changed

+17
-8
lines changed

.github/workflows/cpp-packaging.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -620,8 +620,8 @@ jobs:
620620
fail-fast: false
621621
env:
622622
apis: admob,analytics,auth,database,dynamic_links,firestore,functions,instance_id,messaging,remote_config,storage
623-
android_device: flame
624-
android_api: 29
623+
android_device: walleye
624+
android_api: 27
625625
ios_device: iphone11pro
626626
ios_version: 13.3
627627
steps:

.github/workflows/integration_tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ on:
1717
required: true
1818
android_device:
1919
description: 'Android device model'
20-
default: 'flame'
20+
default: 'walleye'
2121
android_api:
2222
description: 'Android API level'
23-
default: '29'
23+
default: '27'
2424
ios_device:
2525
description: 'iOS device model'
2626
default: 'iphone11pro'

auth/integration_test/src/integration_test.cc

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,13 @@ static const int kPhoneAuthCompletionWaitMs = 8000; // NOLINT
5656
static const int kPhoneAuthTimeoutMs = 0; // NOLINT
5757

5858
// Set these in Firebase Console for your app.
59-
static const char kPhoneAuthTestPhoneNumber[] = "+12345556789"; // NOLINT
60-
static const char kPhoneAuthTestVerificationCode[] = "123456"; // NOLINT
59+
static const char* kPhoneAuthTestPhoneNumbers[] = {
60+
"+12345556780", "+12345556781", "+12345556782", "+12345556783",
61+
"+12345556784", "+12345556785", "+12345556786", "+12345556787",
62+
"+12345556788", "+12345556789"}; // NOLINT
63+
static const char kPhoneAuthTestVerificationCode[] = "123456"; // NOLINT
64+
static const int kPhoneAuthTestNumPhoneNumbers =
65+
sizeof(kPhoneAuthTestPhoneNumbers) / sizeof(kPhoneAuthTestPhoneNumbers[0]);
6166

6267
static const char kTestPassword[] = "testEmailPassword123";
6368
static const char kTestEmailBad[] = "[email protected]";
@@ -860,8 +865,12 @@ TEST_F(FirebaseAuthTest, TestPhoneAuth) {
860865
LogDebug("Creating listener.");
861866
PhoneListener listener;
862867
LogDebug("Calling VerifyPhoneNumber.");
863-
phone_provider.VerifyPhoneNumber(kPhoneAuthTestPhoneNumber,
864-
kPhoneAuthTimeoutMs, nullptr, &listener);
868+
// Randomly choose one of the phone numbers to avoid collisions.
869+
const int random_phone_number =
870+
app_framework::GetCurrentTimeInMicroseconds() % kPhoneAuthTestNumPhoneNumbers;
871+
phone_provider.VerifyPhoneNumber(
872+
kPhoneAuthTestPhoneNumbers[random_phone_number], kPhoneAuthTimeoutMs,
873+
nullptr, &listener);
865874
// Wait for OnCodeSent() callback.
866875
int wait_ms = 0;
867876
LogDebug("Waiting for code send.");

0 commit comments

Comments
 (0)