Skip to content

Commit f979047

Browse files
Fix return codes from new test validation logic
summarize_test_results returned true if all tests passed, which is not what should be returned as a return code. The docstring even says it's supposed to return 0 if all tests pass.
1 parent a701c5c commit f979047

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/gha/integration_testing/test_validation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ def summarize_test_results(tests, platform, summary_dir):
200200
logging.info(summary)
201201
write_summary(summary_dir, summary)
202202

203-
return len(tests) == len(successes)
203+
return 0 if len(tests) == len(successes) else 1
204204

205205

206206
def write_summary(testapp_dir, summary):

0 commit comments

Comments
 (0)