Skip to content

Commit fd20579

Browse files
committed
use bash shell for setting env variables
With the new env variable file workflow on github, we have to ensure that our strings are UTF-8 encoded if using power shell. Instead, using bash keeps the action simple and consistent across various desktop platforms.
1 parent e592c1c commit fd20579

File tree

3 files changed

+4
-0
lines changed

3 files changed

+4
-0
lines changed

.github/workflows/android.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ jobs:
3030
submodules: true
3131

3232
- name: Set env variables for subsequent steps (all)
33+
shell: bash
3334
run: |
3435
echo "MATRIX_UNIQUE_NAME=${{ matrix.os }}-${{ matrix.architecture }}" >> $GITHUB_ENV
3536
echo "GHA_INSTALL_CCACHE=1" >> $GITHUB_ENV

.github/workflows/desktop.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ jobs:
4545
submodules: true
4646

4747
- name: Set env variables for subsequent steps (all)
48+
shell: bash
4849
run: |
4950
echo "VCPKG_RESPONSE_FILE=external/vcpkg_custom_data/response_files/${{ matrix.architecture }}-${{ matrix.vcpkg_triplet_suffix }}.txt" >> $GITHUB_ENV
5051
echo "MATRIX_UNIQUE_NAME=${{ matrix.os }}-${{ matrix.build_type }}-${{ matrix.architecture }}-${{ matrix.msvc_runtime }}" >> $GITHUB_ENV

.github/workflows/integration_tests.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,11 @@ jobs:
7171
if: startsWith(matrix.os, 'macos')
7272
run: echo "VCPKG_TRIPLET=x64-osx" >> $GITHUB_ENV
7373
- name: Set env vars (windows)
74+
shell: bash
7475
if: startsWith(matrix.os, 'windows')
7576
run: echo "VCPKG_TRIPLET=x64-windows-static" >> $GITHUB_ENV
7677
- name: Set env vars(all)
78+
shell: bash
7779
run: echo "VCPKG_RESPONSE_FILE=external/vcpkg_${{ env.VCPKG_TRIPLET }}_response_file.txt" >> $GITHUB_ENV
7880

7981
- name: Add msbuild to PATH (windows)

0 commit comments

Comments
 (0)