remove(integration_test): Storage V1 delete tests

Author: exaby73

integration_test/.env.example

@@ -10,4 +10,4 @@ FIREBASE_APP_ID=
 FIREBASE_MEASUREMENT_ID=
 FIREBASE_AUTH_DOMAIN=
 FIREBASE_API_KEY=
-GOOGLE_ANALYTICS_API_SECRET=
+GOOGLE_ANALYTICS_API_SECRET=

integration_test/functions/src/v1/storage-tests.ts

@@ -3,6 +3,7 @@ import * as functions from "firebase-functions";
 import { REGION } from "../region";
 import { sanitizeData } from "../utils";
 
+// TODO: (b/372315689) Re-enable function once bug is fixed
 // export const storageOnDeleteTests: any = functions
 //   .runWith({
 //     timeoutSeconds: 540,
@@ -24,26 +25,26 @@ import { sanitizeData } from "../utils";
 //       .set(sanitizeData(context));
 //   });
 
-// export const storageOnFinalizeTests: any = functions
-//   .runWith({
-//     timeoutSeconds: 540,
-//   })
-//   .region(REGION)
-//   .storage.bucket()
-//   .object()
-//   .onFinalize(async (object, context) => {
-//     const testId = object.name?.split(".")[0];
-//     if (!testId) {
-//       functions.logger.error("TestId not found for storage object finalize");
-//       return;
-//     }
-//
-//     await admin
-//       .firestore()
-//       .collection("storageOnFinalizeTests")
-//       .doc(testId)
-//       .set(sanitizeData(context));
-//   });
+export const storageOnFinalizeTests: any = functions
+  .runWith({
+    timeoutSeconds: 540,
+  })
+  .region(REGION)
+  .storage.bucket()
+  .object()
+  .onFinalize(async (object, context) => {
+    const testId = object.name?.split(".")[0];
+    if (!testId) {
+      functions.logger.error("TestId not found for storage object finalize");
+      return;
+    }
+
+    await admin
+      .firestore()
+      .collection("storageOnFinalizeTests")
+      .doc(testId)
+      .set(sanitizeData(context));
+  });
 
 export const storageOnMetadataUpdateTests: any = functions
   .runWith({

integration_test/package.json.template

@@ -10,7 +10,6 @@
   },
   "main": "lib/index.js",
   "devDependencies": {
-    "@types/node-fetch": "^2.6.1",
     "typescript": "^5.3.3"
   },
   "engines": {

integration_test/tests/v1/storage.test.ts

@@ -29,8 +29,7 @@ describe("Firebase Storage", () => {
     await admin.firestore().collection("storageOnMetadataUpdateTests").doc(testId).delete();
   });
 
-  // FIXME: Re-enable after fix
-  describe.skip("object onFinalize trigger", () => {
+  describe("object onFinalize trigger", () => {
     let loggedContext: admin.firestore.DocumentData | undefined;
 
     beforeAll(async () => {
@@ -78,7 +77,7 @@ describe("Firebase Storage", () => {
     });
   });
 
-  // FIXME: Re-enable after fix
+  // TODO: (b/372315689) Re-enable function once bug is fixed
   describe.skip("object onDelete trigger", () => {
     let loggedContext: admin.firestore.DocumentData | undefined;