fix(integration_tests): fix storage tests

Author: cabljac

integration_test_declarative/scripts/generate.js

@@ -155,6 +155,11 @@ for (const suite of suites) {
     timestamp: new Date().toISOString(),
   };
 
+  // Debug: Log the context for storage templates
+  if (service === "storage") {
+    console.log("   🔍 Debug - Template context:", JSON.stringify(context, null, 2));
+  }
+
   // Generate the test file for this suite
   generateFromTemplate(templatePath, `functions/src/${version}/${service}-tests.ts`, context);
 

integration_test_declarative/scripts/run-suite.sh

@@ -173,12 +173,17 @@ echo -e "${GREEN}☁️  Step 3/4: Deploying to Firebase${NC}"
 echo -e "${BLUE}──────────────────────────────────────────────────────────${NC}"
 
 cd "$ROOT_DIR/generated"
-firebase deploy --only functions --project "$PROJECT_ID" || {
+
+# Source the utility functions for retry logic
+source "$ROOT_DIR/scripts/util.sh"
+
+# Deploy with exponential backoff retry
+retry_with_backoff 3 30 120 600 firebase deploy --only functions --project "$PROJECT_ID" || {
   # Check if it's just the cleanup policy warning
   if firebase functions:list --project "$PROJECT_ID" 2>/dev/null | grep -q "$TEST_RUN_ID"; then
     echo -e "${YELLOW}⚠️  Functions deployed with warnings (cleanup policy)${NC}"
   else
-    echo -e "${RED}❌ Deployment failed${NC}"
+    echo -e "${RED}❌ Deployment failed after all retry attempts${NC}"
     exit 1
   fi
 }
@@ -202,6 +207,25 @@ fi
 # Run the tests
 export GOOGLE_APPLICATION_CREDENTIALS="$ROOT_DIR/sa.json"
 
+# Extract deployed functions from suite names
+DEPLOYED_FUNCTIONS=""
+for SUITE_NAME in "${SUITE_NAMES[@]}"; do
+  case "$SUITE_NAME" in
+    v1_auth_nonblocking)
+      DEPLOYED_FUNCTIONS="${DEPLOYED_FUNCTIONS},onCreate,onDelete"
+      ;;
+    v1_auth_before_create)
+      DEPLOYED_FUNCTIONS="${DEPLOYED_FUNCTIONS},beforeCreate"
+      ;;
+    v1_auth_before_signin)
+      DEPLOYED_FUNCTIONS="${DEPLOYED_FUNCTIONS},beforeSignIn"
+      ;;
+  esac
+done
+
+# Remove leading comma
+DEPLOYED_FUNCTIONS="${DEPLOYED_FUNCTIONS#,}"
+
 # Collect test files for all suites
 TEST_FILES=()
 for SUITE_NAME in "${SUITE_NAMES[@]}"; do
@@ -267,10 +291,10 @@ for SUITE_NAME in "${SUITE_NAMES[@]}"; do
 done
 
 if [ ${#TEST_FILES[@]} -gt 0 ]; then
-  TEST_RUN_ID="$TEST_RUN_ID" npm test -- "${TEST_FILES[@]}"
+  DEPLOYED_FUNCTIONS="$DEPLOYED_FUNCTIONS" TEST_RUN_ID="$TEST_RUN_ID" npm test -- "${TEST_FILES[@]}"
 else
   echo -e "${YELLOW}   No test files found. Running all tests...${NC}"
-  TEST_RUN_ID="$TEST_RUN_ID" npm test
+  DEPLOYED_FUNCTIONS="$DEPLOYED_FUNCTIONS" TEST_RUN_ID="$TEST_RUN_ID" npm test
 fi
 
 echo ""

integration_test_declarative/templates/functions/src/v1/storage-tests.ts.hbs

@@ -10,7 +10,7 @@ export const {{name}}{{../testRunId}} = functions
     timeoutSeconds: {{timeout}}
   })
   .region(REGION)
-  .storage.bucket("functions-integration-tests.firebasestorage.app")
+  .storage.bucket("{{../projectId}}.firebasestorage.app")
   .object()
   .{{trigger}}(async (object{{#if (eq trigger "onFinalize")}}: unknown{{/if}}, context) => {
     {{#if (eq trigger "onFinalize")}}

integration_test_declarative/tests/v1/auth.test.ts

@@ -1,13 +1,19 @@
 import * as admin from "firebase-admin";
 import { initializeApp } from "firebase/app";
-import { createUserWithEmailAndPassword, getAuth, UserCredential } from "firebase/auth";
+import {
+  createUserWithEmailAndPassword,
+  signInWithEmailAndPassword,
+  getAuth,
+  UserCredential,
+} from "firebase/auth";
 import { initializeFirebase } from "../firebaseSetup";
 import { retry } from "../utils";
 
 describe("Firebase Auth (v1)", () => {
   const userIds: string[] = [];
   const projectId = process.env.PROJECT_ID || "functions-integration-tests";
   const testId = process.env.TEST_RUN_ID;
+  const deployedFunctions = process.env.DEPLOYED_FUNCTIONS?.split(",") || [];
 
   if (!testId) {
     throw new Error("Environment configured incorrectly.");
@@ -17,13 +23,15 @@ describe("Firebase Auth (v1)", () => {
   let config;
   try {
     // Try to load from test-config.json first
-    config = require('../../test-config.json');
+    config = require("../../test-config.json");
     config.projectId = config.projectId || projectId;
   } catch {
     // Fall back to environment variables
     const apiKey = process.env.FIREBASE_API_KEY;
     if (!apiKey) {
-      console.warn("Skipping Auth tests: No test-config.json found and FIREBASE_API_KEY not configured");
+      console.warn(
+        "Skipping Auth tests: No test-config.json found and FIREBASE_API_KEY not configured"
+      );
       test.skip("Auth tests require Firebase client SDK configuration", () => {});
       return;
     }
@@ -161,6 +169,11 @@ describe("Firebase Auth (v1)", () => {
     let loggedContext: admin.firestore.DocumentData | undefined;
 
     beforeAll(async () => {
+      if (!deployedFunctions.includes("beforeCreate")) {
+        console.log("⏭️  Skipping beforeCreate tests - function not deployed in this suite");
+        return;
+      }
+
       const auth = getAuth(app);
       userCredential = await createUserWithEmailAndPassword(
         auth,
@@ -184,14 +197,26 @@ describe("Firebase Auth (v1)", () => {
     });
 
     it("should have the correct eventType", () => {
+      if (!deployedFunctions.includes("beforeCreate")) {
+        pending("beforeCreate function not deployed in this suite");
+        return;
+      }
       expect(loggedContext?.eventType).toEqual("providers/cloud.auth/eventTypes/user.beforeCreate");
     });
 
     it("should have an eventId", () => {
+      if (!deployedFunctions.includes("beforeCreate")) {
+        pending("beforeCreate function not deployed in this suite");
+        return;
+      }
       expect(loggedContext?.eventId).toBeDefined();
     });
 
     it("should have a timestamp", () => {
+      if (!deployedFunctions.includes("beforeCreate")) {
+        pending("beforeCreate function not deployed in this suite");
+        return;
+      }
       expect(loggedContext?.timestamp).toBeDefined();
     });
   });
@@ -202,6 +227,11 @@ describe("Firebase Auth (v1)", () => {
     let loggedContext: admin.firestore.DocumentData | undefined;
 
     beforeAll(async () => {
+      if (!deployedFunctions.includes("beforeSignIn")) {
+        console.log("⏭️  Skipping beforeSignIn tests - function not deployed in this suite");
+        return;
+      }
+
       userRecord = await admin.auth().createUser({
         email: `${testId}@beforesignin.com`,
         password: "secret456",
@@ -210,7 +240,8 @@ describe("Firebase Auth (v1)", () => {
       userIds.push(userRecord.uid);
 
       const auth = getAuth(app);
-      userCredential = await createUserWithEmailAndPassword(
+      // Fix: Use signInWithEmailAndPassword instead of createUserWithEmailAndPassword
+      userCredential = await signInWithEmailAndPassword(
         auth,
         `${testId}@beforesignin.com`,
         "secret456"
@@ -231,15 +262,27 @@ describe("Firebase Auth (v1)", () => {
     });
 
     it("should have the correct eventType", () => {
+      if (!deployedFunctions.includes("beforeSignIn")) {
+        pending("beforeSignIn function not deployed in this suite");
+        return;
+      }
       expect(loggedContext?.eventType).toEqual("providers/cloud.auth/eventTypes/user.beforeSignIn");
     });
 
     it("should have an eventId", () => {
+      if (!deployedFunctions.includes("beforeSignIn")) {
+        pending("beforeSignIn function not deployed in this suite");
+        return;
+      }
       expect(loggedContext?.eventId).toBeDefined();
     });
 
     it("should have a timestamp", () => {
+      if (!deployedFunctions.includes("beforeSignIn")) {
+        pending("beforeSignIn function not deployed in this suite");
+        return;
+      }
       expect(loggedContext?.timestamp).toBeDefined();
     });
   });
-});
+});