fix linters and test setup.

Author: taeold

spec/helper.ts

@@ -40,7 +40,11 @@ export interface RunHandlerResult {
  * data populated into the response.
  */
 export function runHandler(
-  handler: express.Handler,
+  handler: (
+    req: https.Request,
+    res: express.Response,
+    next?: express.NextFunction
+  ) => void | Promise<void>,
   request: https.Request
 ): Promise<RunHandlerResult> {
   return new Promise((resolve) => {
@@ -119,7 +123,7 @@ export function runHandler(
       }
     }
     const response = new MockResponse();
-    handler(request, response as any, () => undefined);
+    return void handler(request, response as any, () => undefined);
   });
 }
 

spec/v1/providers/httpsAsync.spec.ts

@@ -17,21 +17,25 @@ describe("CloudHttpsBuilder async onRequest", () => {
   });
 
   it("should catch and log unhandled rejections in async onRequest handlers", async () => {
-    const error = new Error("Async error");
+    const err = new Error("boom");
     const fn = https.onRequest(async (_req, _res) => {
-      throw error;
+      await Promise.resolve();
+      throw err;
     });
 
     const req = new MockRequest({}, {});
     req.method = "GET";
 
-    await runHandler(fn, req as any);
+    const result = await runHandler(fn, req as any);
 
-    expect(loggerSpy.calledWith("Unhandled error", error)).to.be.true;
+    expect(loggerSpy.calledWith("Unhandled error", err)).to.be.true;
+    expect(result.status).to.equal(500);
+    expect(result.body).to.equal("Internal Server Error");
   });
 
   it("should not log if handler completes successfully", async () => {
     const fn = https.onRequest(async (_req, res) => {
+      await Promise.resolve();
       res.send(200);
     });
 

spec/v2/providers/httpsAsync.spec.ts

@@ -17,21 +17,25 @@ describe("v2.https.onRequest async", () => {
   });
 
   it("should catch and log unhandled rejections in async onRequest handlers", async () => {
-    const error = new Error("Async error v2");
+    const err = new Error("boom");
     const fn = https.onRequest(async (_req, _res) => {
-      throw error;
+      await Promise.resolve();
+      throw err;
     });
 
     const req = new MockRequest({}, {});
     req.method = "GET";
 
-    await runHandler(fn, req as any);
+    const result = await runHandler(fn, req as any);
 
-    expect(loggerSpy.calledWith("Unhandled error", error)).to.be.true;
+    expect(loggerSpy.calledWith("Unhandled error", err)).to.be.true;
+    expect(result.status).to.equal(500);
+    expect(result.body).to.equal("Internal Server Error");
   });
 
   it("should not log if handler completes successfully", async () => {
     const fn = https.onRequest(async (_req, res) => {
+      await Promise.resolve();
       res.send(200);
     });