Migrate endpoint annotation eventTrigger.eventFilters to list of filters (#1052)

Previously, `eventFilter` attribute was an object:

```
eventTrigger: {
  eventType: "an.event",
  eventFilter: {
    resource: "my-storage-bucket",
    appId: "12345",
  }
}
```

We now prefer eventFilter as a list:

```
eventTrigger: {
  eventType: "an.event",
  eventFilter: [
  {
    attribute: "resource",
    value: "my-storage-bucket",
  }.
  {
    attribute: "appId",
    value: "12345",
  }.
  ]
}
```

Most of the change in this PR is in tests. Few other minor changes I've squeezed in here:

1. Added a changelog entry for #1037
2. Deleted obsolete src/common/manifest.ts file
3. Small refactoring of alerts/crashlytics spec to make this migration easier.

Author: taeold

CHANGELOG.md

@@ -0,0 +1 @@
+- Add support for more regions and memory for v2 functions (#1037).

spec/runtime/loader.spec.ts

@@ -122,7 +122,12 @@ describe('extractStack', () => {
           platform: 'gcfv1',
           eventTrigger: {
             eventType: 'google.pubsub.topic.publish',
-            eventFilters: { resource: 'projects/my-project/topics/my-topic' },
+            eventFilters: [
+              {
+                attribute: 'resource',
+                value: 'projects/my-project/topics/my-topic',
+              },
+            ],
             retry: false,
           },
           labels: {},

spec/v1/cloud-functions.spec.ts

@@ -62,9 +62,12 @@ describe('makeCloudFunction', () => {
       platform: 'gcfv1',
       eventTrigger: {
         eventType: 'mock.provider.mock.event',
-        eventFilters: {
-          resource: 'resource',
-        },
+        eventFilters: [
+          {
+            attribute: 'resource',
+            value: 'resource',
+          },
+        ],
         retry: false,
       },
       labels: {},
@@ -86,9 +89,12 @@ describe('makeCloudFunction', () => {
       platform: 'gcfv1',
       eventTrigger: {
         eventType: 'providers/provider/eventTypes/event',
-        eventFilters: {
-          resource: 'resource',
-        },
+        eventFilters: [
+          {
+            attribute: 'resource',
+            value: 'resource',
+          },
+        ],
         retry: false,
       },
       labels: {},
@@ -119,9 +125,12 @@ describe('makeCloudFunction', () => {
       serviceAccountEmail: '[email protected]',
       eventTrigger: {
         eventType: 'mock.provider.mock.event',
-        eventFilters: {
-          resource: 'resource',
-        },
+        eventFilters: [
+          {
+            attribute: 'resource',
+            value: 'resource',
+          },
+        ],
         retry: false,
       },
       secretEnvironmentVariables: [{ secret: 'MY_SECRET', key: 'MY_SECRET' }],
@@ -143,9 +152,12 @@ describe('makeCloudFunction', () => {
       platform: 'gcfv1',
       eventTrigger: {
         eventType: 'mock.provider.mock.event',
-        eventFilters: {
-          resource: 'resource',
-        },
+        eventFilters: [
+          {
+            attribute: 'resource',
+            value: 'resource',
+          },
+        ],
         retry: true,
       },
       labels: {},

spec/v1/providers/analytics.spec.ts

@@ -72,9 +72,12 @@ describe('Analytics Functions', () => {
         expect(cloudFunction.__endpoint).to.deep.equal({
           platform: 'gcfv1',
           eventTrigger: {
-            eventFilters: {
-              resource: 'projects/project1/events/first_open',
-            },
+            eventFilters: [
+              {
+                attribute: 'resource',
+                value: 'projects/project1/events/first_open',
+              },
+            ],
             eventType:
               'providers/google.firebase.analytics/eventTypes/event.log',
             retry: false,

spec/v1/providers/auth.spec.ts

@@ -64,9 +64,12 @@ describe('Auth Functions', () => {
       return {
         platform: 'gcfv1',
         eventTrigger: {
-          eventFilters: {
-            resource: `projects/${project}`,
-          },
+          eventFilters: [
+            {
+              attribute: 'resource',
+              value: `projects/${project}`,
+            },
+          ],
           eventType: `providers/firebase.auth/eventTypes/${eventType}`,
           retry: false,
         },

spec/v1/providers/database.spec.ts

@@ -45,9 +45,12 @@ describe('Database Functions', () => {
       return {
         platform: 'gcfv1',
         eventTrigger: {
-          eventFilters: {
-            resource,
-          },
+          eventFilters: [
+            {
+              attribute: 'resource',
+              value: resource,
+            },
+          ],
           eventType: `providers/google.firebase.database/eventTypes/${eventType}`,
           retry: false,
         },

spec/v1/providers/firestore.spec.ts

@@ -107,9 +107,12 @@ describe('Firestore Functions', () => {
       return {
         platform: 'gcfv1',
         eventTrigger: {
-          eventFilters: {
-            resource,
-          },
+          eventFilters: [
+            {
+              attribute: 'resource',
+              value: resource,
+            },
+          ],
           eventType: `providers/cloud.firestore/eventTypes/${eventType}`,
           retry: false,
         },

spec/v1/providers/pubsub.spec.ts

@@ -108,9 +108,12 @@ describe('Pubsub Functions', () => {
           platform: 'gcfv1',
           eventTrigger: {
             eventType: 'google.pubsub.topic.publish',
-            eventFilters: {
-              resource: 'projects/project1/topics/toppy',
-            },
+            eventFilters: [
+              {
+                attribute: 'resource',
+                value: 'projects/project1/topics/toppy',
+              },
+            ],
             retry: false,
           },
           labels: {},

spec/v1/providers/remoteConfig.spec.ts

@@ -68,9 +68,12 @@ describe('RemoteConfig Functions', () => {
         platform: 'gcfv1',
         eventTrigger: {
           eventType: 'google.firebase.remoteconfig.update',
-          eventFilters: {
-            resource: 'projects/project1',
-          },
+          eventFilters: [
+            {
+              attribute: 'resource',
+              value: 'projects/project1',
+            },
+          ],
           retry: false,
         },
         labels: {},

spec/v1/providers/storage.spec.ts

@@ -42,9 +42,12 @@ describe('Storage Functions', () => {
       return {
         platform: 'gcfv1',
         eventTrigger: {
-          eventFilters: {
-            resource: `projects/_/buckets/${bucket}`,
-          },
+          eventFilters: [
+            {
+              attribute: 'resource',
+              value: `projects/_/buckets/${bucket}`,
+            },
+          ],
           eventType: `google.storage.object.${eventType}`,
           retry: false,
         },