From b285d7a490e5bf3834e43a1b2564053d50b772e1 Mon Sep 17 00:00:00 2001 From: exaby73 Date: Thu, 1 Aug 2024 15:55:09 +0530 Subject: [PATCH 1/6] fix: retry param ignored for RTDB triggers --- src/v2/providers/database.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/v2/providers/database.ts b/src/v2/providers/database.ts index 50400bdcf..178def022 100644 --- a/src/v2/providers/database.ts +++ b/src/v2/providers/database.ts @@ -447,7 +447,7 @@ export function makeEndpoint( eventType, eventFilters, eventFilterPathPatterns, - retry: false, + retry: opts.retry, }, }; } @@ -459,6 +459,7 @@ export function onChangedOperation( handler: (event: DatabaseEvent, ParamsOf>) => any | Promise ): CloudFunction, ParamsOf>> { const { path, instance, opts } = getOpts(referenceOrOpts); + console.log(opts); const pathPattern = new PathPattern(path); const instancePattern = new PathPattern(instance); From fb79faf0e03f796442e87ab3308124b39d116402 Mon Sep 17 00:00:00 2001 From: exaby73 Date: Thu, 1 Aug 2024 15:55:54 +0530 Subject: [PATCH 2/6] Remove console.log --- src/v2/providers/database.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/v2/providers/database.ts b/src/v2/providers/database.ts index 178def022..50d7eadfb 100644 --- a/src/v2/providers/database.ts +++ b/src/v2/providers/database.ts @@ -459,7 +459,6 @@ export function onChangedOperation( handler: (event: DatabaseEvent, ParamsOf>) => any | Promise ): CloudFunction, ParamsOf>> { const { path, instance, opts } = getOpts(referenceOrOpts); - console.log(opts); const pathPattern = new PathPattern(path); const instancePattern = new PathPattern(instance); From 2710322c3c398ece064bacf6d4e2b179f9c53a90 Mon Sep 17 00:00:00 2001 From: exaby73 Date: Thu, 1 Aug 2024 16:01:13 +0530 Subject: [PATCH 3/6] feat: Default to false --- src/v2/providers/database.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v2/providers/database.ts b/src/v2/providers/database.ts index 50d7eadfb..8bccbc59b 100644 --- a/src/v2/providers/database.ts +++ b/src/v2/providers/database.ts @@ -447,7 +447,7 @@ export function makeEndpoint( eventType, eventFilters, eventFilterPathPatterns, - retry: opts.retry, + retry: opts.retry ?? false, }, }; } From 07c0e7f067464fcf7976ef7cee976f613a159f85 Mon Sep 17 00:00:00 2001 From: exaby73 Date: Thu, 1 Aug 2024 16:01:20 +0530 Subject: [PATCH 4/6] test: Add test for retry --- spec/v2/providers/database.spec.ts | 198 +++++++++++++++++------------ 1 file changed, 116 insertions(+), 82 deletions(-) diff --git a/spec/v2/providers/database.spec.ts b/spec/v2/providers/database.spec.ts index c5e16f747..71d86725d 100644 --- a/spec/v2/providers/database.spec.ts +++ b/spec/v2/providers/database.spec.ts @@ -31,7 +31,7 @@ const RAW_RTDB_EVENT: database.RawRTDBCloudEvent = { data: { ["@type"]: "type.googleapis.com/google.events.firebase.database.v1.ReferenceEventData", data: {}, - delta: {}, + delta: {} }, firebasedatabasehost: "firebaseio.com", instance: "my-instance", @@ -41,7 +41,7 @@ const RAW_RTDB_EVENT: database.RawRTDBCloudEvent = { source: "source", specversion: "1.0", time: "time", - type: "type", + type: "type" }; describe("database", () => { @@ -49,7 +49,7 @@ describe("database", () => { it("should make params with basic path", () => { const event: database.RawRTDBCloudEvent = { ...RAW_RTDB_EVENT, - ref: "match_a/something/else/nothing/end/match_b", + ref: "match_a/something/else/nothing/end/match_b" }; expect( @@ -60,14 +60,14 @@ describe("database", () => { ) ).to.deep.equal({ a: "match_a", - b: "match_b", + b: "match_b" }); }); it("should make params with multi segment path", () => { const event: database.RawRTDBCloudEvent = { ...RAW_RTDB_EVENT, - ref: "something/is/a/thing/else/match_a/hello/match_b/world", + ref: "something/is/a/thing/else/match_a/hello/match_b/world" }; expect( @@ -78,14 +78,14 @@ describe("database", () => { ) ).to.deep.equal({ a: "match_a", - b: "match_b", + b: "match_b" }); }); it("should make params with multi segment path capture", () => { const event: database.RawRTDBCloudEvent = { ...RAW_RTDB_EVENT, - ref: "something/is/a/thing/else/match_a/hello/match_b/world", + ref: "something/is/a/thing/else/match_a/hello/match_b/world" }; expect( @@ -97,14 +97,14 @@ describe("database", () => { ).to.deep.equal({ path: "is/a/thing", a: "match_a", - b: "match_b", + b: "match_b" }); }); it("should make params for a full path and instance", () => { const event: database.RawRTDBCloudEvent = { ...RAW_RTDB_EVENT, - ref: "something/is/a/thing/else/match_a/hello/match_b/world", + ref: "something/is/a/thing/else/match_a/hello/match_b/world" }; expect( @@ -116,7 +116,7 @@ describe("database", () => { ).to.deep.equal({ path: "is/a/thing", a: "match_a", - b: "match_b", + b: "match_b" }); }); }); @@ -126,7 +126,7 @@ describe("database", () => { expect(database.getOpts("/foo/{bar}/")).to.deep.equal({ path: "foo/{bar}", instance: "*", - opts: {}, + opts: {} }); }); @@ -134,14 +134,14 @@ describe("database", () => { expect( database.getOpts({ ref: "/foo/{bar}/", - region: "us-central1", + region: "us-central1" }) ).to.deep.equal({ path: "foo/{bar}", instance: "*", opts: { - region: "us-central1", - }, + region: "us-central1" + } }); }); }); @@ -152,7 +152,7 @@ describe("database", () => { database.writtenEventType, { region: "us-central1", - labels: { 1: "2" }, + labels: { 1: "2" } }, new PathPattern("foo/bar"), new PathPattern("*") @@ -162,7 +162,7 @@ describe("database", () => { ...MINIMAL_V2_ENDPOINT, platform: "gcfv2", labels: { - 1: "2", + 1: "2" }, region: ["us-central1"], eventTrigger: { @@ -170,10 +170,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/bar", - instance: "*", + instance: "*" }, - retry: false, - }, + retry: false + } }); }); @@ -182,7 +182,7 @@ describe("database", () => { database.writtenEventType, { region: "us-central1", - labels: { 1: "2" }, + labels: { 1: "2" } }, new PathPattern("foo/bar"), new PathPattern("my-instance") @@ -192,19 +192,19 @@ describe("database", () => { ...MINIMAL_V2_ENDPOINT, platform: "gcfv2", labels: { - 1: "2", + 1: "2" }, region: ["us-central1"], eventTrigger: { eventType: database.writtenEventType, eventFilters: { - instance: "my-instance", + instance: "my-instance" }, eventFilterPathPatterns: { - ref: "foo/bar", + ref: "foo/bar" }, - retry: false, - }, + retry: false + } }); }); }); @@ -222,10 +222,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*", + instance: "*" }, - retry: false, - }, + retry: false + } }); }); @@ -241,10 +241,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*", + instance: "*" }, - retry: false, - }, + retry: false + } }); }); @@ -256,7 +256,7 @@ describe("database", () => { instance: "my-instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2, + minInstances: 2 }, () => 2 ); @@ -271,13 +271,47 @@ describe("database", () => { eventTrigger: { eventType: database.writtenEventType, eventFilters: { - instance: "my-instance", + instance: "my-instance" }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}", + ref: "foo/{path=**}/{bar}" }, - retry: false, + retry: false + } + }); + }); + + it("should supply retry", () => { + const func = database.onChangedOperation( + database.writtenEventType, + { + ref: "/foo/{path=**}/{bar}/", + instance: "my-instance", + region: "us-central1", + cpu: "gcf_gen1", + minInstances: 2, + retry: true, }, + () => 2 + ); + + expect(func.__endpoint).to.deep.equal({ + ...MINIMAL_V2_ENDPOINT, + platform: "gcfv2", + cpu: "gcf_gen1", + minInstances: 2, + region: ["us-central1"], + labels: {}, + eventTrigger: { + eventType: database.writtenEventType, + eventFilters: { + instance: "my-instance" + }, + eventFilterPathPatterns: { + ref: "foo/{path=**}/{bar}" + }, + retry: true + } }); }); }); @@ -295,10 +329,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*", + instance: "*" }, - retry: false, - }, + retry: false + } }); }); @@ -314,10 +348,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*", + instance: "*" }, - retry: false, - }, + retry: false + } }); }); @@ -329,7 +363,7 @@ describe("database", () => { instance: "my-instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2, + minInstances: 2 }, () => 2 ); @@ -344,13 +378,13 @@ describe("database", () => { eventTrigger: { eventType: database.createdEventType, eventFilters: { - instance: "my-instance", + instance: "my-instance" }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}", + ref: "foo/{path=**}/{bar}" }, - retry: false, - }, + retry: false + } }); }); }); @@ -370,10 +404,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*", + instance: "*" }, - retry: false, - }, + retry: false + } }); }); @@ -384,7 +418,7 @@ describe("database", () => { instance: "my-instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2, + minInstances: 2 }, (event) => { expectType<{ path: string; bar: string }>(event.params); @@ -401,13 +435,13 @@ describe("database", () => { eventTrigger: { eventType: database.writtenEventType, eventFilters: { - instance: "my-instance", + instance: "my-instance" }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}", + ref: "foo/{path=**}/{bar}" }, - retry: false, - }, + retry: false + } }); }); @@ -418,7 +452,7 @@ describe("database", () => { source: "source", type: "type", time: "now", - data: "data", + data: "data" }; let hello; @@ -444,10 +478,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*", + instance: "*" }, - retry: false, - }, + retry: false + } }); }); @@ -458,7 +492,7 @@ describe("database", () => { instance: "instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2, + minInstances: 2 }, (event) => { expectType<{ @@ -478,13 +512,13 @@ describe("database", () => { eventTrigger: { eventType: database.createdEventType, eventFilters: { - instance: "instance", + instance: "instance" }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}", + ref: "foo/{path=**}/{bar}" }, - retry: false, - }, + retry: false + } }); }); @@ -495,7 +529,7 @@ describe("database", () => { source: "source", type: "type", time: "now", - data: "data", + data: "data" }; let hello; @@ -521,10 +555,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*", + instance: "*" }, - retry: false, - }, + retry: false + } }); }); @@ -535,7 +569,7 @@ describe("database", () => { instance: "my-instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2, + minInstances: 2 }, (event) => { expectType<{ path: string; bar: string }>(event.params); @@ -552,13 +586,13 @@ describe("database", () => { eventTrigger: { eventType: database.updatedEventType, eventFilters: { - instance: "my-instance", + instance: "my-instance" }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}", + ref: "foo/{path=**}/{bar}" }, - retry: false, - }, + retry: false + } }); }); @@ -569,7 +603,7 @@ describe("database", () => { source: "source", type: "type", time: "now", - data: "data", + data: "data" }; let hello; @@ -595,10 +629,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*", + instance: "*" }, - retry: false, - }, + retry: false + } }); }); @@ -609,7 +643,7 @@ describe("database", () => { instance: "my-instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2, + minInstances: 2 }, (event) => { expectType<{ path: string; bar: string }>(event.params); @@ -626,13 +660,13 @@ describe("database", () => { eventTrigger: { eventType: database.deletedEventType, eventFilters: { - instance: "my-instance", + instance: "my-instance" }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}", + ref: "foo/{path=**}/{bar}" }, - retry: false, - }, + retry: false + } }); }); @@ -643,7 +677,7 @@ describe("database", () => { source: "source", type: "type", time: "now", - data: "data", + data: "data" }; let hello; From e7172abca534671efdeaf03af6cde032d207df3c Mon Sep 17 00:00:00 2001 From: exaby73 Date: Thu, 1 Aug 2024 16:04:10 +0530 Subject: [PATCH 5/6] chore: Remove formatting changes --- spec/v2/providers/database.spec.ts | 174 ++++++++++++++--------------- 1 file changed, 87 insertions(+), 87 deletions(-) diff --git a/spec/v2/providers/database.spec.ts b/spec/v2/providers/database.spec.ts index 71d86725d..9eabf61ca 100644 --- a/spec/v2/providers/database.spec.ts +++ b/spec/v2/providers/database.spec.ts @@ -31,7 +31,7 @@ const RAW_RTDB_EVENT: database.RawRTDBCloudEvent = { data: { ["@type"]: "type.googleapis.com/google.events.firebase.database.v1.ReferenceEventData", data: {}, - delta: {} + delta: {}, }, firebasedatabasehost: "firebaseio.com", instance: "my-instance", @@ -41,7 +41,7 @@ const RAW_RTDB_EVENT: database.RawRTDBCloudEvent = { source: "source", specversion: "1.0", time: "time", - type: "type" + type: "type", }; describe("database", () => { @@ -49,7 +49,7 @@ describe("database", () => { it("should make params with basic path", () => { const event: database.RawRTDBCloudEvent = { ...RAW_RTDB_EVENT, - ref: "match_a/something/else/nothing/end/match_b" + ref: "match_a/something/else/nothing/end/match_b", }; expect( @@ -60,14 +60,14 @@ describe("database", () => { ) ).to.deep.equal({ a: "match_a", - b: "match_b" + b: "match_b", }); }); it("should make params with multi segment path", () => { const event: database.RawRTDBCloudEvent = { ...RAW_RTDB_EVENT, - ref: "something/is/a/thing/else/match_a/hello/match_b/world" + ref: "something/is/a/thing/else/match_a/hello/match_b/world", }; expect( @@ -78,14 +78,14 @@ describe("database", () => { ) ).to.deep.equal({ a: "match_a", - b: "match_b" + b: "match_b", }); }); it("should make params with multi segment path capture", () => { const event: database.RawRTDBCloudEvent = { ...RAW_RTDB_EVENT, - ref: "something/is/a/thing/else/match_a/hello/match_b/world" + ref: "something/is/a/thing/else/match_a/hello/match_b/world", }; expect( @@ -97,14 +97,14 @@ describe("database", () => { ).to.deep.equal({ path: "is/a/thing", a: "match_a", - b: "match_b" + b: "match_b", }); }); it("should make params for a full path and instance", () => { const event: database.RawRTDBCloudEvent = { ...RAW_RTDB_EVENT, - ref: "something/is/a/thing/else/match_a/hello/match_b/world" + ref: "something/is/a/thing/else/match_a/hello/match_b/world", }; expect( @@ -116,7 +116,7 @@ describe("database", () => { ).to.deep.equal({ path: "is/a/thing", a: "match_a", - b: "match_b" + b: "match_b", }); }); }); @@ -126,7 +126,7 @@ describe("database", () => { expect(database.getOpts("/foo/{bar}/")).to.deep.equal({ path: "foo/{bar}", instance: "*", - opts: {} + opts: {}, }); }); @@ -134,14 +134,14 @@ describe("database", () => { expect( database.getOpts({ ref: "/foo/{bar}/", - region: "us-central1" + region: "us-central1", }) ).to.deep.equal({ path: "foo/{bar}", instance: "*", opts: { - region: "us-central1" - } + region: "us-central1", + }, }); }); }); @@ -152,7 +152,7 @@ describe("database", () => { database.writtenEventType, { region: "us-central1", - labels: { 1: "2" } + labels: { 1: "2" }, }, new PathPattern("foo/bar"), new PathPattern("*") @@ -162,7 +162,7 @@ describe("database", () => { ...MINIMAL_V2_ENDPOINT, platform: "gcfv2", labels: { - 1: "2" + 1: "2", }, region: ["us-central1"], eventTrigger: { @@ -170,10 +170,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/bar", - instance: "*" + instance: "*", }, - retry: false - } + retry: false, + }, }); }); @@ -182,7 +182,7 @@ describe("database", () => { database.writtenEventType, { region: "us-central1", - labels: { 1: "2" } + labels: { 1: "2" }, }, new PathPattern("foo/bar"), new PathPattern("my-instance") @@ -192,19 +192,19 @@ describe("database", () => { ...MINIMAL_V2_ENDPOINT, platform: "gcfv2", labels: { - 1: "2" + 1: "2", }, region: ["us-central1"], eventTrigger: { eventType: database.writtenEventType, eventFilters: { - instance: "my-instance" + instance: "my-instance", }, eventFilterPathPatterns: { - ref: "foo/bar" + ref: "foo/bar", }, - retry: false - } + retry: false, + }, }); }); }); @@ -222,10 +222,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*" + instance: "*", }, - retry: false - } + retry: false, + }, }); }); @@ -241,10 +241,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*" + instance: "*", }, - retry: false - } + retry: false, + }, }); }); @@ -256,7 +256,7 @@ describe("database", () => { instance: "my-instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2 + minInstances: 2, }, () => 2 ); @@ -271,13 +271,13 @@ describe("database", () => { eventTrigger: { eventType: database.writtenEventType, eventFilters: { - instance: "my-instance" + instance: "my-instance", }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}" + ref: "foo/{path=**}/{bar}", }, - retry: false - } + retry: false, + }, }); }); @@ -305,13 +305,13 @@ describe("database", () => { eventTrigger: { eventType: database.writtenEventType, eventFilters: { - instance: "my-instance" + instance: "my-instance", }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}" + ref: "foo/{path=**}/{bar}", }, - retry: true - } + retry: true, + }, }); }); }); @@ -329,10 +329,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*" + instance: "*", }, - retry: false - } + retry: false, + }, }); }); @@ -348,10 +348,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*" + instance: "*", }, - retry: false - } + retry: false, + }, }); }); @@ -363,7 +363,7 @@ describe("database", () => { instance: "my-instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2 + minInstances: 2, }, () => 2 ); @@ -378,13 +378,13 @@ describe("database", () => { eventTrigger: { eventType: database.createdEventType, eventFilters: { - instance: "my-instance" + instance: "my-instance", }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}" + ref: "foo/{path=**}/{bar}", }, - retry: false - } + retry: false, + }, }); }); }); @@ -404,10 +404,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*" + instance: "*", }, - retry: false - } + retry: false, + }, }); }); @@ -418,7 +418,7 @@ describe("database", () => { instance: "my-instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2 + minInstances: 2, }, (event) => { expectType<{ path: string; bar: string }>(event.params); @@ -435,13 +435,13 @@ describe("database", () => { eventTrigger: { eventType: database.writtenEventType, eventFilters: { - instance: "my-instance" + instance: "my-instance", }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}" + ref: "foo/{path=**}/{bar}", }, - retry: false - } + retry: false, + }, }); }); @@ -452,7 +452,7 @@ describe("database", () => { source: "source", type: "type", time: "now", - data: "data" + data: "data", }; let hello; @@ -478,10 +478,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*" + instance: "*", }, - retry: false - } + retry: false, + }, }); }); @@ -492,7 +492,7 @@ describe("database", () => { instance: "instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2 + minInstances: 2, }, (event) => { expectType<{ @@ -512,13 +512,13 @@ describe("database", () => { eventTrigger: { eventType: database.createdEventType, eventFilters: { - instance: "instance" + instance: "instance", }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}" + ref: "foo/{path=**}/{bar}", }, - retry: false - } + retry: false, + }, }); }); @@ -529,7 +529,7 @@ describe("database", () => { source: "source", type: "type", time: "now", - data: "data" + data: "data", }; let hello; @@ -555,10 +555,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*" + instance: "*", }, - retry: false - } + retry: false, + }, }); }); @@ -569,7 +569,7 @@ describe("database", () => { instance: "my-instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2 + minInstances: 2, }, (event) => { expectType<{ path: string; bar: string }>(event.params); @@ -586,13 +586,13 @@ describe("database", () => { eventTrigger: { eventType: database.updatedEventType, eventFilters: { - instance: "my-instance" + instance: "my-instance", }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}" + ref: "foo/{path=**}/{bar}", }, - retry: false - } + retry: false, + }, }); }); @@ -603,7 +603,7 @@ describe("database", () => { source: "source", type: "type", time: "now", - data: "data" + data: "data", }; let hello; @@ -629,10 +629,10 @@ describe("database", () => { eventFilters: {}, eventFilterPathPatterns: { ref: "foo/{bar}", - instance: "*" + instance: "*", }, - retry: false - } + retry: false, + }, }); }); @@ -643,7 +643,7 @@ describe("database", () => { instance: "my-instance", region: "us-central1", cpu: "gcf_gen1", - minInstances: 2 + minInstances: 2, }, (event) => { expectType<{ path: string; bar: string }>(event.params); @@ -660,13 +660,13 @@ describe("database", () => { eventTrigger: { eventType: database.deletedEventType, eventFilters: { - instance: "my-instance" + instance: "my-instance", }, eventFilterPathPatterns: { - ref: "foo/{path=**}/{bar}" + ref: "foo/{path=**}/{bar}", }, - retry: false - } + retry: false, + }, }); }); @@ -677,7 +677,7 @@ describe("database", () => { source: "source", type: "type", time: "now", - data: "data" + data: "data", }; let hello; From 59f91312109acbf5fc68f633219dc417445d5bd5 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Thu, 22 Aug 2024 11:14:48 -0700 Subject: [PATCH 6/6] Add changelog. --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e69de29bb..7fabc8933 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -0,0 +1 @@ +- Expose retry configuration in v2 RTDB trigger (#1588)