Fix release failure by adding Linux rolldown bindings #1759
Conversation
The release build in Cloud Build (Linux) was failing because `npm ci` could not find the `@rolldown/binding-linux-x64-gnu` native binding. This is a known issue when lockfiles are generated on non-Linux OSes. Explicitly adding it to `optionalDependencies` ensures it's included in `package-lock.json` and correctly installed by `npm ci` on Linux, while being safely skipped on other platforms.
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical Cloud Build failure on Linux by ensuring the necessary Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a Cloud Build failure on Linux by explicitly adding the @rolldown/binding-linux-x64-gnu package to optionalDependencies. This ensures that npm ci can find and install the necessary native binding on Linux environments, even when the lockfile is generated on another OS. The changes to package.json and package-lock.json are appropriate for this fix. I have one comment regarding the long-term maintainability of this dependency version.
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
taeold
changed the title
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
3 participants
The release build in Cloud Build (Linux) was failing because
npm cicould not find the@rolldown/binding-linux-x64-gnunative binding. This is a known issue when lockfiles are generated on non-Linux OSes.Explicitly adding it to
optionalDependenciesensures it's included inpackage-lock.jsonand correctly installed bynpm cion Linux, while being safely skipped on other platforms.