Skip to content

Commit 051d84b

Browse files
committed
Review fixes
1 parent 00edd58 commit 051d84b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Firestore/core/src/local/globals_cache.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@
2020

2121
#include "Firestore/core/src/nanopb/byte_string.h"
2222

23+
using firebase::firestore::nanopb::ByteString;
24+
2325
namespace firebase {
2426
namespace firestore {
2527
namespace local {
2628

27-
using nanopb::ByteString;
28-
2929
/**
3030
* General purpose cache for global values.
3131
*

Firestore/core/src/local/leveldb_key.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -769,7 +769,7 @@ class LevelDbNamedQueryKey {
769769
};
770770

771771
/**
772-
* A key in the globals table, storing the bundle Id for each entry.
772+
* A key in the globals table, storing the name of the global value.
773773
*/
774774
class LevelDbGlobalKey {
775775
public:
@@ -779,7 +779,7 @@ class LevelDbGlobalKey {
779779
static std::string KeyPrefix();
780780

781781
/**
782-
* Creates a key that points to the key for the given global name.
782+
* Creates a key that points to the key for the given name of global value.
783783
*/
784784
static std::string Key(absl::string_view global_name);
785785

@@ -794,7 +794,7 @@ class LevelDbGlobalKey {
794794
ABSL_MUST_USE_RESULT
795795
bool Decode(absl::string_view key);
796796

797-
/** The global name for this entry. */
797+
/** The name that serves as identifier for global value for this entry. */
798798
const std::string& global_name() const {
799799
return global_name_;
800800
}

0 commit comments

Comments
 (0)