Skip to content

Commit 05ca814

Browse files
authored
Fix a property name in FirebaseInAppMessaging (#13788)
1 parent 6d724ca commit 05ca814

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

FirebaseInAppMessaging/Sources/Flows/FIRIAMMessageClientCache.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,15 @@ - (void)setupAnalyticsEventListening {
108108
}
109109
}
110110

111-
if (self.analycisEventDislayCheckFlow) {
111+
if (self.analyticsEventDisplayCheckFlow) {
112112
if ([self.firebaseAnalyticEventsToWatch count] > 0) {
113113
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM160010",
114114
@"There are analytics event trigger based messages, enable listening");
115-
[self.analycisEventDislayCheckFlow start];
115+
[self.analyticsEventDisplayCheckFlow start];
116116
} else {
117117
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM160011",
118118
@"No analytics event trigger based messages, disable listening");
119-
[self.analycisEventDislayCheckFlow stop];
119+
[self.analyticsEventDisplayCheckFlow stop];
120120
}
121121
}
122122
}

FirebaseInAppMessaging/Sources/Private/Flows/FIRIAMMessageClientCache.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ API_AVAILABLE(ios(13.0), tvos(13.0))
5757
// analytics event listening based on the latest message definitions
5858
// make it weak to avoid retaining cycle
5959
@property(nonatomic, weak, nullable)
60-
FIRIAMDisplayCheckOnAnalyticEventsFlow *analycisEventDislayCheckFlow;
60+
FIRIAMDisplayCheckOnAnalyticEventsFlow *analyticsEventDisplayCheckFlow;
6161

6262
- (instancetype)init NS_UNAVAILABLE;
6363
- (instancetype)initWithBookkeeper:(id<FIRIAMBookKeeper>)bookKeeper

FirebaseInAppMessaging/Sources/Runtime/FIRIAMRuntimeManager.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,7 @@ - (void)internalStartRuntimeWithSDKSettings:(FIRIAMSDKSettings *)settings {
369369
self.displayOnFIRAnalyticEventsFlow =
370370
[[FIRIAMDisplayCheckOnAnalyticEventsFlow alloc] initWithDisplayFlow:self.displayExecutor];
371371

372-
self.messageCache.analycisEventDislayCheckFlow = self.displayOnFIRAnalyticEventsFlow;
372+
self.messageCache.analyticsEventDisplayCheckFlow = self.displayOnFIRAnalyticEventsFlow;
373373
[self.messageCache
374374
loadMessageDataFromServerFetchStorage:self.fetchResultStorage
375375
withCompletion:^(BOOL success) {

FirebaseInAppMessaging/Tests/Unit/FIRIAMMessageClientCacheTests.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ - (void)testCallingStartAnalyticsEventListenFlow_ok {
325325

326326
FIRIAMDisplayCheckOnAnalyticEventsFlow *mockAnalyticsEventFlow =
327327
OCMClassMock(FIRIAMDisplayCheckOnAnalyticEventsFlow.class);
328-
self.clientCache.analycisEventDislayCheckFlow = mockAnalyticsEventFlow;
328+
self.clientCache.analyticsEventDisplayCheckFlow = mockAnalyticsEventFlow;
329329

330330
// m2 and m4 are messages rendered on 'test_event' Firebase Analytics event
331331
// so we expect the analytics event listening flow to be started
@@ -339,7 +339,7 @@ - (void)testCallingStopAnalyticsEventListenFlow_ok {
339339

340340
FIRIAMDisplayCheckOnAnalyticEventsFlow *mockAnalyticsEventFlow =
341341
OCMClassMock(FIRIAMDisplayCheckOnAnalyticEventsFlow.class);
342-
self.clientCache.analycisEventDislayCheckFlow = mockAnalyticsEventFlow;
342+
self.clientCache.analyticsEventDisplayCheckFlow = mockAnalyticsEventFlow;
343343

344344
// m1 and m3 are messages rendered on app foreground triggers
345345
OCMExpect([mockAnalyticsEventFlow stop]);
@@ -352,7 +352,7 @@ - (void)testCallingStartAndThenStopAnalyticsEventListenFlow_ok {
352352

353353
FIRIAMDisplayCheckOnAnalyticEventsFlow *mockAnalyticsEventFlow =
354354
OCMClassMock(FIRIAMDisplayCheckOnAnalyticEventsFlow.class);
355-
self.clientCache.analycisEventDislayCheckFlow = mockAnalyticsEventFlow;
355+
self.clientCache.analyticsEventDisplayCheckFlow = mockAnalyticsEventFlow;
356356

357357
// start is triggered on the setMessageData: call
358358
OCMExpect([mockAnalyticsEventFlow start]);

0 commit comments

Comments
 (0)