Skip to content

Commit 06c1a50

Browse files
authored
Fix build_non_firebase_sdks.sh for 7.x Swift pods (#7396)
1 parent e7119ca commit 06c1a50

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
env:
1919
bot_token_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
2020
local_repo: specstesting
21-
nightly_version: "6.32.1"
21+
nightly_version: "7.5.0"
2222
local_sdk_repo_dir: /tmp/test/firebase-ios-sdk
2323
podspec_repo_branch: master
2424
runs-on: macOS-latest

.github/workflows/zip.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ on:
55
paths:
66
- 'ReleaseTooling/**'
77
- '.github/workflows/zip.yml'
8+
- 'scripts/build_non_firebase_sdks.sh'
89
- 'Gemfile'
910
# Don't run based on any markdown only changes.
1011
- '!ReleaseTooling/*.md'

scripts/build_non_firebase_sdks.sh

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,13 @@ num_sdk="${#NON_FIREBASE_SDKS[@]}"
2727
echo "[" >> "${ZIP_POD_JSON}"
2828
for sdk in "${NON_FIREBASE_SDKS[@]}"
2929
do
30-
echo "{\"name\":\"${sdk}\"}" >> "${ZIP_POD_JSON}"
30+
if [ ${sdk} == "FirebaseFirestoreSwift" ]; then
31+
echo "{\"name\":\"FirebaseFirestoreSwift\", \"version\" : \"~> 7.5-beta\"}" >> "${ZIP_POD_JSON}"
32+
elif [ ${sdk} == "FirebaseStorageSwift" ]; then
33+
echo "{\"name\":\"FirebaseStorageSwift\", \"version\" : \"~> 7.5-beta\"}" >> "${ZIP_POD_JSON}"
34+
else
35+
echo "{\"name\":\"${sdk}\"}" >> "${ZIP_POD_JSON}"
36+
fi
3137
if [ "$num_sdk" -ne 1 ]; then
3238
echo ",">> "${ZIP_POD_JSON}"
3339
fi
@@ -42,5 +48,3 @@ unzip -o "${REPO}"/sdk_zip/Frameworks.zip -d "${HOME}"/ios_frameworks/Firebase/
4248

4349
# Move Frameworks to Firebase dir, so be align with Firebase SDKs.
4450
mv -n "${HOME}"/ios_frameworks/Firebase/Binaries "${HOME}"/ios_frameworks/Firebase/NonFirebaseSDKs/
45-
46-

scripts/create_spec_repo/Sources/SpecRepoBuilder/main.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,8 @@ struct SpecRepoBuilder: ParsableCommand {
244244
)
245245
shell.run("pod repo update")
246246

247+
print("Outcome is \(outcome)")
248+
247249
return outcome
248250
}
249251

@@ -344,6 +346,7 @@ struct SpecRepoBuilder: ParsableCommand {
344346
if podExitCode != 0 {
345347
exitCode = 1
346348
failedPods.append(pod)
349+
print("Failed pod - \(pod)")
347350
}
348351
}
349352
if exitCode != 0 {

0 commit comments

Comments
 (0)