Removed Development tests

Author: JesusRojass

FirebasePerformance/Tests/Unit/FPRTraceBackgroundActivityTrackerTest.m

@@ -83,44 +83,17 @@ - (void)testObservers_synchronousRegistrationAddsObserver {
 
 /** Tests rapid creation and deallocation to verify race condition fix. */
 - (void)testRapidCreationAndDeallocation_noRaceCondition {
-  // This test simulates the real crash scenario by forcing async dispatch timing
-  XCTestExpectation *expectation =
-      [self expectationWithDescription:@"All async operations complete"];
-
-  __block int completedOperations = 0;
-  const int totalOperations = 50;
-
-  for (int i = 0; i < totalOperations; i++) {
+  for (int i = 0; i < 100; i++) {
     @autoreleasepool {
       FPRTraceBackgroundActivityTracker *tracker = [[FPRTraceBackgroundActivityTracker alloc] init];
       XCTAssertNotNil(tracker);
 
-      // Force multiple runloop cycles to increase chance of race condition
-      dispatch_async(dispatch_get_main_queue(), ^{
-        // This would crash with old async registration if tracker is deallocated
-        [[NSNotificationCenter defaultCenter]
-            postNotificationName:UIApplicationDidBecomeActiveNotification
-                          object:[UIApplication sharedApplication]];
-
-        // Increment counter and fulfill expectation when done
-        completedOperations++;
-        if (completedOperations == totalOperations) {
-          [expectation fulfill];
-        }
-      });
-
-      // Tracker deallocates here immediately due to @autoreleasepool
+      [[NSNotificationCenter defaultCenter]
+          postNotificationName:UIApplicationDidBecomeActiveNotification
+                        object:[UIApplication sharedApplication]];
     }
   }
 
-  // Wait for all async operations to complete
-  [self waitForExpectationsWithTimeout:10.0
-                               handler:^(NSError *error) {
-                                 XCTAssertNil(
-                                     error, @"Operations timed out - potential deadlock or crash");
-                               }];
-
-  // Additional safety check - post more notifications after everything is done
   XCTAssertNoThrow([[NSNotificationCenter defaultCenter]
       postNotificationName:UIApplicationDidBecomeActiveNotification
                     object:[UIApplication sharedApplication]]);
@@ -166,108 +139,4 @@ - (void)testObservers_registrationFromBackgroundThread {
                                }];
 }
 
-/** Tests the exact crash scenario with async dispatch timing that would crash with old
- * implementation. */
-- (void)testAsyncDispatch_wouldCrashWithOldImplementation {
-  // This test simulates what the OLD code would do and should crash with async registration
-  // With the NEW synchronous code, this should pass safely
-
-  XCTestExpectation *expectation = [self expectationWithDescription:@"Async crash test complete"];
-
-  __block int remainingOperations = 200;
-
-  for (int i = 0; i < 200; i++) {
-    @autoreleasepool {
-      FPRTraceBackgroundActivityTracker *tracker = [[FPRTraceBackgroundActivityTracker alloc] init];
-      XCTAssertNotNil(tracker);
-
-      // Simulate the old problematic pattern
-      __weak typeof(tracker) weakTracker = tracker;
-
-      // This mimics what the OLD async registration would do
-      dispatch_async(dispatch_get_main_queue(), ^{
-        // In old code: tracker might be deallocated here → CRASH
-        // In new code: observers already registered synchronously → SAFE
-
-        if (weakTracker) {
-          [[NSNotificationCenter defaultCenter]
-              postNotificationName:UIApplicationDidBecomeActiveNotification
-                            object:[UIApplication sharedApplication]];
-        }
-
-        remainingOperations--;
-        if (remainingOperations == 0) {
-          [expectation fulfill];
-        }
-      });
-
-      // Immediately deallocate tracker - this creates the race condition window
-    }
-
-    // Force runloop processing to increase race condition likelihood
-    [[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:0.001]];
-  }
-
-  [self waitForExpectationsWithTimeout:5.0
-                               handler:^(NSError *error) {
-                                 XCTAssertNil(error, @"Async crash test failed");
-                               }];
-}
-
-@end
-
-/**
- * CRASH REPRODUCTION TEST - Only use this to verify the original bug exists
- * This simulates the original async registration pattern that would cause crashes
- */
-
-@interface CrashReproductionTracker : NSObject
-@property(nonatomic, readwrite) int traceBackgroundState;
-@end
-
-@implementation CrashReproductionTracker
-
-- (instancetype)init {
-  self = [super init];
-  if (self) {
-    _traceBackgroundState = 0;
-
-    // This is the ORIGINAL problematic code that would crash
-    dispatch_async(dispatch_get_main_queue(), ^{
-      [[NSNotificationCenter defaultCenter] addObserver:self
-                                               selector:@selector(handleNotification:)
-                                                   name:UIApplicationDidBecomeActiveNotification
-                                                 object:[UIApplication sharedApplication]];
-    });
-  }
-  return self;
-}
-
-- (void)handleNotification:(NSNotification *)notification {
-  _traceBackgroundState = 1;
-}
-
-- (void)dealloc {
-  [[NSNotificationCenter defaultCenter] removeObserver:self];
-}
-
-/**
- * CRASH REPRODUCTION TEST - Only use this to verify the original bug exists
- * This simulates the original async registration pattern that would cause crashes
- * WARNING: This test is commented out because it WILL crash with the original async pattern
- */
-
-- (void)testCrashReproduction_originalAsyncBug {
-  // This test WILL crash with the original async pattern
-  for (int i = 0; i < 100; i++) {
-    @autoreleasepool {
-      CrashReproductionTracker *tracker = [[CrashReproductionTracker alloc] init];
-      // tracker deallocates here, but async block is still queued → CRASH
-    }
-
-    // Process run loop to execute queued async blocks
-    [[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:0.01]];
-  }
-}
-
 @end