change APIs

Author: cherylEnkidu

Firestore/Swift/Source/ExprImpl.swift

@@ -283,11 +283,6 @@ public extension Expression {
     return FunctionExpression("str_concat", [self] + strings)
   }
 
-  func strConcat(_ strings: [String]) -> FunctionExpression {
-    let exprs = [self] + strings.map { Helper.sendableToExpr($0) }
-    return FunctionExpression("str_concat", exprs)
-  }
-
   func reverse() -> FunctionExpression {
     return FunctionExpression("reverse", [self])
   }

Firestore/Swift/Source/SwiftAPI/Pipeline/Expression.swift

@@ -739,7 +739,7 @@ public protocol Expression: Sendable {
   /// Assumes `self` evaluates to a string.
   ///
   /// ```swift
-  /// // Convert the "title" field to uppercase
+  /// // Convert the "title" field to uppercase3
   /// Field("title").uppercased()
   /// ```
   ///
@@ -772,19 +772,6 @@ public protocol Expression: Sendable {
   /// - Returns: A new `FunctionExpression` representing the concatenated string.
   func strConcat(_ strings: [Expression]) -> FunctionExpression
 
-  /// Creates an expression that concatenates this string expression with other string literals.
-  /// Assumes `self` evaluates to a string.
-  ///
-  /// ```swift
-  /// // Combine "firstName" field with " " and "lastName"
-  /// Field("firstName").strConcat(" ", "lastName")
-  /// ```
-  ///
-  /// - Parameter secondString: A string literal to concatenate.
-  /// - Parameter otherStrings: Optional additional string literals to concatenate.
-  /// - Returns: A new `FunctionExpression` representing the concatenated string.
-  func strConcat(_ strings: [String]) -> FunctionExpression
-
   /// Creates an expression that reverses this string expression.
   /// Assumes `self` evaluates to a string.
   ///

Firestore/Swift/Source/SwiftAPI/Pipeline/Expressions/FunctionExpressions/BooleanExpression.swift

@@ -21,8 +21,9 @@ public class BooleanExpression: FunctionExpression, @unchecked Sendable {
     return AggregateFunction("count_if", [self])
   }
 
-  public func then(_ thenExpr: Expression, else elseExpr: Expression) -> FunctionExpression {
-    return FunctionExpression("cond", [self, thenExpr, elseExpr])
+  public func then(_ thenExpression: Expression,
+                   else elseExpression: Expression) -> FunctionExpression {
+    return FunctionExpression("cond", [self, thenExpression, elseExpression])
   }
 
   public static func && (lhs: BooleanExpression,

Firestore/Swift/Source/SwiftAPI/Pipeline/Pipeline.swift

@@ -265,7 +265,7 @@ public struct Pipeline: @unchecked Sendable {
   /// // let pipeline: Pipeline = ... // Assume initial pipeline, possibly sorted.
   /// // Retrieve the second page of 20 results (skip first 20, limit to next 20).
   /// let pagedPipeline = pipeline
-  ///                     .sort(Ascending("published")) // Example sort.
+  ///                     .sort(Field("published").ascending()) // Example sort.
   ///                     .offset(20)  // Skip the first 20 results.
   ///                     .limit(20)   // Take the next 20 results.
   /// // let results = try await pagedPipeline.execute()
@@ -627,7 +627,7 @@ public struct Pipeline: @unchecked Sendable {
   ///   - params: An array of ordered, `Sendable` parameters for the stage.
   ///   - options: Optional dictionary of named, `Sendable` parameters.
   /// - Returns: A new `Pipeline` object with this stage appended.
-  public func rawStage(name: String, params: [Sendable?],
+  public func rawStage(name: String, params: [Sendable],
                        options: [String: Sendable]? = nil) -> Pipeline {
     return Pipeline(
       stages: stages + [RawStage(name: name, params: params, options: options)],

Firestore/Swift/Source/SwiftAPI/Stages.swift

@@ -349,10 +349,10 @@ class Unnest: Stage {
 class RawStage: Stage {
   let name: String
   let bridge: StageBridge
-  private var params: [Sendable?]
+  private var params: [Sendable]
   private var options: [String: Sendable]?
 
-  init(name: String, params: [Sendable?], options: [String: Sendable]? = nil) {
+  init(name: String, params: [Sendable], options: [String: Sendable]? = nil) {
     self.name = name
     self.params = params
     self.options = options