[App Distribution] Remove typedefs (#6281)

Stop using typedefs for completion blocks in public APIs so that Xcode is more usable in Swift:

Author: jeremydurham

FirebaseAppDistribution/Sources/FIRAppDistribution.m

@@ -247,7 +247,8 @@ - (NSError *_Nullable)mapFetchReleasesError:(NSError *)error {
                                      message:@"Failed to fetch releases for unknown reason."];
 }
 
-- (void)fetchNewLatestRelease:(FIRAppDistributionUpdateCheckCompletion)completion {
+- (void)fetchNewLatestRelease:(void (^)(FIRAppDistributionRelease *_Nullable release,
+                                        NSError *_Nullable error))completion {
   [FIRFADApiService
       fetchReleasesWithCompletion:^(NSArray *_Nullable releases, NSError *_Nullable error) {
         if (error) {
@@ -283,7 +284,8 @@ - (void)fetchNewLatestRelease:(FIRAppDistributionUpdateCheckCompletion)completio
       }];
 }
 
-- (void)checkForUpdateWithCompletion:(FIRAppDistributionUpdateCheckCompletion)completion {
+- (void)checkForUpdateWithCompletion:(void (^)(FIRAppDistributionRelease *_Nullable release,
+                                               NSError *_Nullable error))completion {
   FIRFADInfoLog(@"CheckForUpdateWithCompletion");
   if ([self isTesterSignedIn]) {
     [self fetchNewLatestRelease:completion];

FirebaseAppDistribution/Sources/Public/FIRAppDistribution.h

@@ -17,20 +17,6 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
-/**
- *  @related AppDistributionError
- *
- *  The completion handler invoked when the new build request returns.
- *  If the call fails we return the appropriate `error code`, described by
- *  `AppDistributionError`.
- *
- *  @param release  The new release that is available to be installed.
- *  @param error     The error describing why the new build request failed.
- */
-typedef void (^FIRAppDistributionUpdateCheckCompletion)(
-    FIRAppDistributionRelease *_Nullable release, NSError *_Nullable error)
-    NS_SWIFT_NAME(AppDistributionUpdateCheckCompletion);
-
 /**
  * The Firebase App Distribution API provides methods to check for update to
  * the app and returns information that enables updating the app.
@@ -58,7 +44,8 @@ NS_SWIFT_NAME(AppDistribution)
 /**
  * Check to see whether a new distribution is available
  */
-- (void)checkForUpdateWithCompletion:(FIRAppDistributionUpdateCheckCompletion)completion
+- (void)checkForUpdateWithCompletion:
+    (void (^)(FIRAppDistributionRelease *_Nullable release, NSError *_Nullable error))completion
     NS_SWIFT_NAME(checkForUpdate(completion:));
 
 /**

FirebaseAppDistribution/Tests/Unit/FIRAppDistributionTests.m

@@ -35,7 +35,8 @@ @interface FIRAppDistribution (PrivateUnitTesting)
 
 - (instancetype)initWithApp:(FIRApp *)app appInfo:(NSDictionary *)appInfo;
 
-- (void)fetchNewLatestRelease:(FIRAppDistributionUpdateCheckCompletion)completion;
+- (void)fetchNewLatestRelease:(void (^)(FIRAppDistributionRelease *_Nullable release,
+                                        NSError *_Nullable error))completion;
 
 - (NSError *)mapFetchReleasesError:(NSError *)error;