Fixed analyze issues introduced in Xcode 12.5 (#8210)

Author: paulb777

.swiftpm/xcode/xcshareddata/xcschemes/AuthUnit.xcscheme

@@ -5,6 +5,22 @@
    <BuildAction
       parallelizeBuildables = "YES"
       buildImplicitDependencies = "YES">
+      <BuildActionEntries>
+         <BuildActionEntry
+            buildForTesting = "YES"
+            buildForRunning = "NO"
+            buildForProfiling = "NO"
+            buildForArchiving = "NO"
+            buildForAnalyzing = "YES">
+            <BuildableReference
+               BuildableIdentifier = "primary"
+               BlueprintIdentifier = "AuthUnit"
+               BuildableName = "AuthUnit"
+               BlueprintName = "AuthUnit"
+               ReferencedContainer = "container:">
+            </BuildableReference>
+         </BuildActionEntry>
+      </BuildActionEntries>
    </BuildAction>
    <TestAction
       buildConfiguration = "Debug"

FirebaseAuth/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 8.2.0
+- [fixed] Fixed analyze issues introduced in Xcode 12.5. (#8210)
+
 # 8.0.0
 - [fixed] Fixed a crash that occurred when assigning auth settings (#7670).
 

FirebaseAuth/Sources/AuthProvider/Phone/FIRPhoneAuthProvider.m

@@ -245,7 +245,7 @@ + (instancetype)providerWithAuth:(FIRAuth *)auth {
     @param error The error that occurred if any.
     @return The reCAPTCHA token if successful.
  */
-- (NSString *)reCAPTCHATokenForURL:(NSURL *)URL error:(NSError **)error {
+- (nullable NSString *)reCAPTCHATokenForURL:(NSURL *)URL error:(NSError **_Nonnull)error {
   NSURLComponents *actualURLComponents = [NSURLComponents componentsWithURL:URL
                                                     resolvingAgainstBaseURL:NO];
   NSArray<NSURLQueryItem *> *queryItems = [actualURLComponents queryItems];

FirebaseAuth/Tests/Unit/FIRFakeBackendRPCIssuer.h

@@ -61,7 +61,7 @@ NS_ASSUME_NONNULL_BEGIN
     @param JSON The JSON to return.
     @param error The simulated error to return from GTM.
  */
-- (NSData *)respondWithJSON:(nullable NSDictionary *)JSON error:(nullable NSError *)error;
+- (nullable NSData *)respondWithJSON:(nullable NSDictionary *)JSON error:(nullable NSError *)error;
 
 /** @fn respondWithJSONError:
     @brief Responds to a pending RPC request with a JSON server error.

FirebaseAuth/Tests/Unit/FIRFakeBackendRPCIssuer.m

@@ -60,7 +60,7 @@ - (NSData *)respondWithServerErrorMessage:(NSString *)errorMessage {
   return [self respondWithServerErrorMessage:errorMessage error:error];
 }
 
-- (NSData *)respondWithJSON:(NSDictionary *)JSON error:(NSError *)error {
+- (nullable NSData *)respondWithJSON:(NSDictionary *)JSON error:(NSError *)error {
   NSError *JSONEncodingError;
   NSData *data;
   if (JSON) {