Remove Clearcut dependency. (#7210)

* Remove Clearcut dependency.

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Keep cleanupClearcutCacheDirectory method.

Author: jeremyjiang-dev

FirebasePerformance/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Unreleased
+* Deprecate Clearcut event transport mechanism.
+
 # Version 7.7.0
 * Add community supported tvOS.
 

FirebasePerformance/Sources/Configurations/FPRConfigurations.h

@@ -187,13 +187,6 @@ FOUNDATION_EXTERN FPRConfigName kFPRConfigInstrumentationEnabled;
  */
 - (uint32_t)memorySamplingFrequencyInBackgroundInMS;
 
-/**
- * Returns a float specifying the transport percentage for FLL. Range [0-100].
- *
- * @return The percentage of devices sending events to FLL.
- */
-- (float_t)fllTransportPercentage;
-
 @end
 
 NS_ASSUME_NONNULL_END

FirebasePerformance/Sources/Configurations/FPRConfigurations.m

@@ -474,36 +474,4 @@ - (uint32_t)memorySamplingFrequencyInBackgroundInMS {
   return samplingFrequency;
 }
 
-#pragma mark - Google Data Transport related configurations.
-
-- (float_t)fllTransportPercentage {
-  // Order of precedence is:
-  //
-  // Any RC config flags exists?
-  //   -> Yes
-  //     -> If Transport flag exists, honor the value (active rollout scenario)
-  //     -> Otherwise, send to Fll (deprecation scenario)
-  //   -> No
-  //     -> Send to clearcut (onboarding scenario)
-  //
-  // If a PList override also exists than that takes the priority
-
-  // By default send to Clearcut
-  float transportPercentage = 0.0f;  // Range [0 - 100]
-
-  if (self.remoteConfigFlags && [self.remoteConfigFlags containsRemoteConfigFlags]) {
-    // If Transport flag exists, honor the value (active rollout scenario)
-    // Otherwise, send to Fll (deprecation scenario)
-    transportPercentage = [self.remoteConfigFlags fllTransportPercentageWithDefaultValue:100.0f];
-  }
-
-  // If a PList override also exists than that takes the priority
-  id plistObject = [self objectForInfoDictionaryKey:@"fllTransportPercentage"];
-  if (plistObject) {
-    transportPercentage = [plistObject floatValue];
-  }
-
-  return transportPercentage;
-}
-
 @end

FirebasePerformance/Sources/Configurations/FPRRemoteConfigFlags.h

@@ -40,13 +40,6 @@
  */
 - (void)update;
 
-/**
- * Returns if there was a successful fetch in the past and if any remote config flag exists.
- *
- * @return YES if any remote config flag exists; NO otherwise.
- */
-- (BOOL)containsRemoteConfigFlags;
-
 #pragma mark - General configs.
 
 /**
@@ -207,17 +200,4 @@
  */
 - (int)sessionMaxDurationWithDefaultValue:(int)maxDurationInMinutes;
 
-#pragma mark - Google Data Transport related configs.
-
-/**
- * Returns the fll event transport percentage. A value of 100 means all the events are sent to
- * Fll. A value of 0 means, event are not sent to FLL. Range [0-100]. A value of -1 means
- * the value is not found. Name in remote config: "fpr_log_transport_ios_percent"
- *
- * @param percentage Default value of the transport rate to be returned if value does not exist
- * in remote config.
- * @return FLL transport percentage.
- */
-- (float)fllTransportPercentageWithDefaultValue:(float)percentage;
-
 @end

FirebasePerformance/Sources/Configurations/FPRRemoteConfigFlags.m

@@ -95,7 +95,6 @@ - (instancetype)initWithRemoteConfig:(FIRRemoteConfig *)config {
     [keysToCache setObject:@(FPRConfigValueTypeInteger)
                     forKey:@"fpr_session_gauge_memory_capture_frequency_bg_ms"];
     [keysToCache setObject:@(FPRConfigValueTypeInteger) forKey:@"fpr_session_max_duration_min"];
-    [keysToCache setObject:@(FPRConfigValueTypeFloat) forKey:@"fpr_log_transport_ios_percent"];
     self.configKeys = [keysToCache copy];
 
     [self update];
@@ -136,19 +135,6 @@ - (void)update {
   }
 }
 
-- (BOOL)containsRemoteConfigFlags {
-  // Ideally this should not be tied to any specific flag but since "fpr_enabled" is and should
-  // always be available we simply check for its existence to validate that the RC flags exists
-  // in the cache or not.
-  id cachedValueObject = [self cachedValueForConfigFlag:@"fpr_enabled"];
-
-  if (cachedValueObject) {
-    return true;
-  }
-
-  return false;
-}
-
 #pragma mark - Util methods.
 
 - (void)resetCache {
@@ -344,10 +330,4 @@ - (int)sessionMaxDurationWithDefaultValue:(int)maxDurationInMinutes {
                      defaultValue:maxDurationInMinutes];
 }
 
-#pragma mark - Google Data Transport related methods
-
-- (float)fllTransportPercentageWithDefaultValue:(float)percentage {
-  return [self getFloatValueForFlag:@"fpr_log_transport_ios_percent" defaultValue:percentage];
-}
-
 @end

FirebasePerformance/Sources/FPRClient+Private.h

@@ -15,7 +15,7 @@
 #import "FirebasePerformance/ProtoSupport/PerfMetric.pbobjc.h"
 #import "FirebasePerformance/Sources/FPRClient.h"
 
-@class FPRGDTCCLogger;
+@class FPRGDTLogger;
 @class FPRConfigurations;
 @class FIRInstallations;
 
@@ -28,7 +28,7 @@
 @property(nonatomic, getter=isConfigured, readwrite) BOOL configured;
 
 /** GDT Logger to transmit Fireperf events to Google Data Transport. */
-@property(nonatomic) FPRGDTCCLogger *gdtLogger;
+@property(nonatomic) FPRGDTLogger *gdtLogger;
 
 /** The queue group all FPRClient work will run on. Used for testing only. */
 @property(nonatomic, readonly) dispatch_group_t eventsQueueGroup;

FirebasePerformance/Sources/FPRClient.m

@@ -25,7 +25,7 @@
 #import "FirebasePerformance/Sources/FPRConsoleLogger.h"
 #import "FirebasePerformance/Sources/FPRProtoUtils.h"
 #import "FirebasePerformance/Sources/Instrumentation/FPRInstrumentation.h"
-#import "FirebasePerformance/Sources/Loggers/FPRGDTCCLogger.h"
+#import "FirebasePerformance/Sources/Loggers/FPRGDTLogger.h"
 #import "FirebasePerformance/Sources/Timer/FIRTrace+Internal.h"
 #import "FirebasePerformance/Sources/Timer/FIRTrace+Private.h"
 
@@ -117,7 +117,7 @@ - (BOOL)startWithConfiguration:(FPRConfiguration *)config error:(NSError *__auto
 
   dispatch_group_async(self.eventsQueueGroup, self.eventsQueue, ^{
     // Create the Logger for the Perf SDK events to be sent to Google Data Transport.
-    self.gdtLogger = [[FPRGDTCCLogger alloc] initWithLogSource:logSource];
+    self.gdtLogger = [[FPRGDTLogger alloc] initWithLogSource:logSource];
 
 #if __has_include("CoreTelephony/CTTelephonyNetworkInfo.h")
     // Create telephony network information object ahead of time to avoid runtime delays.

FirebasePerformance/Sources/Loggers/FPRGDTCCLogger.h renamed to FirebasePerformance/Sources/Loggers/FPRGDTLogger.h

@@ -19,7 +19,7 @@ NS_ASSUME_NONNULL_BEGIN
 @class FPRMSGPerfMetric;
 
 /** Logger used to dispatch events to Google Data Transport layer. */
-@interface FPRGDTCCLogger : NSObject
+@interface FPRGDTLogger : NSObject
 
 /** Log source initialized against. */
 @property(nonatomic, readonly) NSInteger logSource;
@@ -31,7 +31,7 @@ NS_ASSUME_NONNULL_BEGIN
  * Instantiates an instance of this class.
  *
  * @param logSource The log source for this logger to be used.
- * @return Instance of FPRGDTCCLogger.
+ * @return Instance of FPRGDTLogger.
  */
 - (instancetype)initWithLogSource:(NSInteger)logSource NS_DESIGNATED_INITIALIZER;
 

FirebasePerformance/Sources/Loggers/FPRGDTCCLogger.m renamed to FirebasePerformance/Sources/Loggers/FPRGDTLogger.m

@@ -12,8 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#import "FirebasePerformance/Sources/Loggers/FPRGDTCCLogger.h"
-#import "FirebasePerformance/Sources/Loggers/FPRGDTCCLogger_Private.h"
+#import "FirebasePerformance/Sources/Loggers/FPRGDTLogger.h"
+#import "FirebasePerformance/Sources/Loggers/FPRGDTLogger_Private.h"
 
 #import "FirebasePerformance/Sources/Configurations/FPRConfigurations.h"
 
@@ -25,21 +25,17 @@
 
 #import "FirebasePerformance/ProtoSupport/PerfMetric.pbobjc.h"
 
-@implementation FPRGDTCCLogger
+@implementation FPRGDTLogger
 
 - (instancetype)initWithLogSource:(NSInteger)logSource {
   if (self = [super init]) {
     _logSource = logSource;
 
-    _queue = dispatch_queue_create("com.google.FPRGDTCCLogger", DISPATCH_QUEUE_SERIAL);
+    _queue = dispatch_queue_create("com.google.FPRGDTLogger", DISPATCH_QUEUE_SERIAL);
     _configurations = [FPRConfigurations sharedInstance];
     FPRGDTLogSampler *logSampler = [[FPRGDTLogSampler alloc] init];
     FPRGDTRateLimiter *rateLimiter = [[FPRGDTRateLimiter alloc] init];
 
-    _gdtcctTransport = [[GDTCORTransport alloc] initWithMappingID:@(logSource).stringValue
-                                                     transformers:@[ logSampler, rateLimiter ]
-                                                           target:kGDTCORTargetCCT];
-
     _gdtfllTransport = [[GDTCORTransport alloc] initWithMappingID:@(logSource).stringValue
                                                      transformers:@[ logSampler, rateLimiter ]
                                                            target:kGDTCORTargetFLL];
@@ -59,10 +55,7 @@ - (instancetype)initWithLogSource:(NSInteger)logSource {
 }
 
 - (void)logEvent:(FPRMSGPerfMetric *)event {
-  GDTCORTransport *eventTransporter = self.gdtcctTransport;
-  if ([self shouldSendEventToFll:event]) {
-    eventTransporter = self.gdtfllTransport;
-  }
+  GDTCORTransport *eventTransporter = self.gdtfllTransport;
 
   dispatch_async(self.queue, ^{
     GDTCOREvent *gdtEvent = [eventTransporter eventForTransport];
@@ -76,16 +69,4 @@ - (void)logEvent:(FPRMSGPerfMetric *)event {
   });
 }
 
-- (BOOL)shouldSendEventToFll:(FPRMSGPerfMetric *)event {
-  return ([self.configurations fllTransportPercentage] >= [self instanceSeedForEvent:event]);
-}
-
-- (float)instanceSeedForEvent:(FPRMSGPerfMetric *)event {
-  if (_instanceSeed == -1.0) {
-    // Seed is a float value with range [1 - 100].
-    _instanceSeed = (float)([event.applicationInfo.appInstanceId hash] % 100 + 1);
-  }
-  return _instanceSeed;
-}
-
 @end

FirebasePerformance/Sources/Loggers/FPRGDTCCLogger_Private.h renamed to FirebasePerformance/Sources/Loggers/FPRGDTLogger_Private.h

@@ -14,20 +14,17 @@
 
 #import <Foundation/Foundation.h>
 
-#import "FirebasePerformance/Sources/Loggers/FPRGDTCCLogger.h"
+#import "FirebasePerformance/Sources/Loggers/FPRGDTLogger.h"
 
 #import <GoogleDataTransport/GoogleDataTransport.h>
 #import "FirebasePerformance/Sources/Configurations/FPRConfigurations.h"
 
-/** FPRGDTCCLogger private definition used for unit testing. */
-@interface FPRGDTCCLogger ()
+/** FPRGDTLogger private definition used for unit testing. */
+@interface FPRGDTLogger ()
 
 /** Log source for which the logger is being used. */
 @property(nonatomic, readwrite) NSInteger logSource;
 
-/** Google Data Transport instance for Clearcut. */
-@property(nonatomic, readwrite) GDTCORTransport *gdtcctTransport;
-
 /** Google Data Transport instance for FLL. */
 @property(nonatomic, readwrite) GDTCORTransport *gdtfllTransport;