Fix nightly failure - Xcode 13 exposes NSDictionary ordering assumptions (#8838)

paulb777 · web-flow · commit 1689772c06dd · 2021-10-20T13:20:58.000-07:00
diff --git a/FirebaseStorage/Tests/Unit/FIRStorageUtilsTests.m b/FirebaseStorage/Tests/Unit/FIRStorageUtilsTests.m
@@ -93,7 +93,8 @@ - (void)testSingleItemToQueryString {
 - (void)testMultiItemDictToQueryString {
   NSDictionary *params = @{@"foo" : @"bar", @"baz" : @"qux"};
   NSString *queryString = [FIRStorageUtils queryStringForDictionary:params];
-  XCTAssertEqualObjects(queryString, @"foo=bar&baz=qux");
+  XCTAssertTrue([queryString isEqualToString:@"foo=bar&baz=qux"] ||
+                [queryString isEqualToString:@"baz=qux&foo=bar"]);
 }
 
 - (void)testDefaultRequestForFullPath {

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,8 @@ - (void)testSingleItemToQueryString {`
`93`	`93`	`- (void)testMultiItemDictToQueryString {`
`94`	`94`	`NSDictionary *params = @{@"foo" : @"bar", @"baz" : @"qux"};`
`95`	`95`	`NSString *queryString = [FIRStorageUtils queryStringForDictionary:params];`
`96`		`- XCTAssertEqualObjects(queryString, @"foo=bar&baz=qux");`
	`96`	`+ XCTAssertTrue([queryString isEqualToString:@"foo=bar&baz=qux"] \|\|`
	`97`	`+ [queryString isEqualToString:@"baz=qux&foo=bar"]);`
`97`	`98`	`}`
`98`	`99`
`99`	`100`	`- (void)testDefaultRequestForFullPath {`