change some of the public APIs

Author: cherylEnkidu

Firestore/Swift/Source/ExprImpl.swift

@@ -129,11 +129,11 @@ public extension Expression {
     return BooleanExpression("gt", [self, exprOther])
   }
 
-  func greaterThanOrEqualTo(_ other: Expression) -> BooleanExpression {
+  func greaterThanOrEqual(_ other: Expression) -> BooleanExpression {
     return BooleanExpression("gte", [self, other])
   }
 
-  func greaterThanOrEqualTo(_ other: Sendable) -> BooleanExpression {
+  func greaterThanOrEqual(_ other: Sendable) -> BooleanExpression {
     let exprOther = Helper.sendableToExpr(other)
     return BooleanExpression("gte", [self, exprOther])
   }
@@ -147,11 +147,11 @@ public extension Expression {
     return BooleanExpression("lt", [self, exprOther])
   }
 
-  func lessThanOrEqualTo(_ other: Expression) -> BooleanExpression {
+  func lessThanOrEqual(_ other: Expression) -> BooleanExpression {
     return BooleanExpression("lte", [self, other])
   }
 
-  func lessThanOrEqualTo(_ other: Sendable) -> BooleanExpression {
+  func lessThanOrEqual(_ other: Sendable) -> BooleanExpression {
     let exprOther = Helper.sendableToExpr(other)
     return BooleanExpression("lte", [self, exprOther])
   }

Firestore/Swift/Source/SwiftAPI/Pipeline/AliasedExpression.swift

@@ -13,9 +13,9 @@
 // limitations under the License.
 
 public struct AliasedExpression: Selectable, SelectableWrapper, Sendable {
-  public let alias: String
+  let alias: String
 
-  public let expr: Expression
+  let expr: Expression
 
   init(_ expr: Expression, _ alias: String) {
     self.alias = alias

Firestore/Swift/Source/SwiftAPI/Pipeline/Expression.swift

@@ -371,14 +371,14 @@ public protocol Expression: Sendable {
   ///
   /// - Parameter other: The expression to compare against.
   /// - Returns: A `BooleanExpr` that can be used in `where` clauses.
-  func greaterThanOrEqualTo(_ other: Expression) -> BooleanExpression
+  func greaterThanOrEqual(_ other: Expression) -> BooleanExpression
 
   /// Creates a `BooleanExpr` that returns `true` if this expression is
   /// greater than or equal to the given value.
   ///
   /// - Parameter other: The value to compare against.
   /// - Returns: A `BooleanExpr` that can be used in `where` clauses.
-  func greaterThanOrEqualTo(_ other: Sendable) -> BooleanExpression
+  func greaterThanOrEqual(_ other: Sendable) -> BooleanExpression
 
   /// Creates a `BooleanExpr` that returns `true` if this expression is less
   /// than the given expression.
@@ -399,14 +399,14 @@ public protocol Expression: Sendable {
   ///
   /// - Parameter other: The expression to compare against.
   /// - Returns: A `BooleanExpr` that can be used in `where` clauses.
-  func lessThanOrEqualTo(_ other: Expression) -> BooleanExpression
+  func lessThanOrEqual(_ other: Expression) -> BooleanExpression
 
   /// Creates a `BooleanExpr` that returns `true` if this expression is less
   /// than or equal to the given value.
   ///
   /// - Parameter other: The value to compare against.
   /// - Returns: A `BooleanExpr` that can be used in `where` clauses.
-  func lessThanOrEqualTo(_ other: Sendable) -> BooleanExpression
+  func lessThanOrEqual(_ other: Sendable) -> BooleanExpression
 
   /// Creates a `BooleanExpr` that returns `true` if this expression is equal
   /// to the given expression.

Firestore/Swift/Source/SwiftAPI/Pipeline/Pipeline.swift

@@ -554,7 +554,7 @@ public struct Pipeline: @unchecked Sendable {
   /// // let results = try await combinedPipeline.execute()
   /// ```
   ///
-  /// - Parameter other: An array of at least one `Pipeline` whose documents will be unioned.
+  /// - Parameter other: Another `Pipeline` whose documents will be unioned.
   /// - Returns: A new `Pipeline` object with this stage appended.
   public func union(with other: Pipeline) -> Pipeline {
     return Pipeline(stages: stages + [Union(other: other)], db: db)

Firestore/Swift/Tests/Integration/PipelineApiTests.swift

@@ -310,13 +310,12 @@ final class PipelineApiTests: FSTIntegrationTestCase {
         ]
       )
 
-    // One special Field value is conveniently exposed as static function to help the user reference
-    // reserved field values of __name__.
-    // TBD
-    //    _ = db.pipeline().collection("books")
-    //      .addFields(
-    //        FieldPath.documentID()
-    //      )
+    // One special Field value is conveniently exposed as constructor to help the user reference reserved field values of __name__.
+        _ = db.pipeline().collection("books")
+          .addFields([
+            DocumentId()
+            ]
+          )
   }
 
   func testConstant() async throws {

Firestore/Swift/Tests/Integration/PipelineTests.swift

@@ -1956,7 +1956,7 @@ class PipelineIntegrationTests: FSTIntegrationTestCase {
       .collection(collRef.path)
       .where(
         Field("rating").greaterThan(4.2) &&
-          Field("rating").lessThanOrEqualTo(4.5) &&
+          Field("rating").lessThanOrEqual(4.5) &&
           Field("genre").notEqual("Science Fiction")
       )
       .select(["rating", "title"])
@@ -2338,7 +2338,7 @@ class PipelineIntegrationTests: FSTIntegrationTestCase {
 
     let pipeline = db.pipeline()
       .collection(collRef.path)
-      .aggregate([AggregateFunction("count_if", [Field("rating").greaterThanOrEqualTo(4.5)])
+      .aggregate([AggregateFunction("count_if", [Field("rating").greaterThanOrEqual(4.5)])
           .as("countOfBest")])
 
     let snapshot = try await pipeline.execute()